Package: tableau-parm
Version: 0.2.0-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu xenial ubuntu-patch

Dear Maintainer,

In Ubuntu, we use ld --as-needed by default in the toolchain, and your
package fails to build from source with that option enabled because of the
way libraries are linked.

Even though Debian doesn't use ld --as-needed by default, it is a good idea
to make this change so that (1) we don't have to maintain a delta and (2)
you don't need to change anything in case Debian makes this default in the
future.

You can read more about this option here:
https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

In Ubuntu, the attached patch was applied to achieve the following:

  * Fix FTBFS with ld --as-needed. LP: #832758.

Thanks for considering the patch.

Logan Rosen

-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 
'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-19-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -u tableau-parm-0.2.0/debian/patches/01-makefile.patch tableau-parm-0.2.0/debian/patches/01-makefile.patch
--- tableau-parm-0.2.0/debian/patches/01-makefile.patch
+++ tableau-parm-0.2.0/debian/patches/01-makefile.patch
@@ -20,7 +20,7 @@
  
  build/bin/tableau-parm: build/bin src/tableau-parm.c Makefile
 -	$(CC) $(OPTS) -o $@ -I/usr/local/include -L/usr/local/lib -lsgutils src/tableau-parm.c
-+	$(CC) $(OPTS) -o $@ -I/usr/include -L/usr/lib -lsgutils2 src/tableau-parm.c
++	$(CC) $(OPTS) -o $@ -I/usr/include -L/usr/lib src/tableau-parm.c -lsgutils2
  
  build/doc/man/man1/tableau-parm.1.gz: doc/man/man1/tableau-parm.1.gz
  	mkdir -p build/doc/man/man1

Reply via email to