Hi Nicholas, Am Mittwoch, den 11.11.2015, 10:04 +0000 schrieb Nicholas Bamber: > On 10/11/15 12:17, Nicholas Bamber wrote: > > On 10/11/15 11:59, James McCoy wrote: > > > On Tue, Nov 10, 2015 at 09:56:26AM +0000, Nicholas Bamber wrote: > > > > > > > > On the contrary, I think changing Makefiles is much more > > > appropriate. > > > Installing the completion files in the right place under the > > > right name > > > should happen regardless of whether this is being packaged in > > > Debian or > > > a downstream (possibly non-Debian based) distro, so it should > > > happen as > > > much as possible in the build process, not in the packaging. > > > > > > Cheers, > > > > > > > > > Thanks for the clarification. I#m happy to work on that basis. It > > will > > take slightly longer. > > > James, > My amended patch is ready. I have ran debdiff, sbuild, lintian > etc and > installed it locally and tested it. Everything looks good to me. I > have > it in git locally so if acceptable all I need to do is push it.
I have a few questions about that applied patch: 1) Why do you copy all bash completions to BC_BUILD_DIR? I see no reason for that additional step. 2) Why do you 'pkgnames' into the bash completions directory? There is no such script. Wouldn't it be better to use on of the existing names (like bts) and point all symlinks to that? 3) Why do you create the symlinks via debian/links instead of the Makefile where you do all the other magic? -- Benjamin Drung Debian & Ubuntu Developer
