❦  9 novembre 2015 10:57 GMT, James Page <james.p...@ubuntu.com> :

>     > I don't think this is compatible with multiple HAProxy processes
>     > (nbproc > 1). See how we do that when start-stop-daemon doesn't
>     > support --pid:
>     >
>     >
>     > Hmm - so start-stop-daemon will generate multiple pids into the
>     > pidfile when nbproc > 1?
>     
>     No, haproxy will write multiple PID to the pidfile when nbproc > 1
>     (in
>     haproxy.cfg). I don't think that start-stop-daemon is able to
>     handle
>     multiple PID in pidfile, hence the loop.
>     
>
> Right - I see; I guess the benefit of using start-stop-daemon is that
> it will only kill haproxy processes, whereas the kill loop is
> indiscriminate.

Yes. This is error-prone (and I just noticed that I have the same
problem in my backport of 1.6 for Trusty) but I think that the best for
now is to stay as is. We could create PID files for each PID, but this
won't look clean.
-- 
Make sure comments and code agree.
            - The Elements of Programming Style (Kernighan & Plauger)

Attachment: signature.asc
Description: PGP signature

Reply via email to