On 07.10.2015 15:13 +0200, Gianfranco Costamagna wrote:
Control: owner -1 !
Control: tags -1 moreinfo
Hi Again,
Hi,
Sorry for waiting,
1) d/copyright:
you removed some licenses (e.g. maia, unzip, quazip and so on)
they are still there, some of them just moved from
src/findsubtitles/quazip/unzip.c
to
zlib/contrib/minizip/unzip.c
I prepare dsfg version with dropped zlib dir from sources. It not needed
in Debian.
2) rules: I fail to understand the reason for
"
get-orig-source:
uscan --force-download"
but you can leave it if needed, and the same rule about PREFIX applies here
Fixed.
3) changelog:
https://sources.debian.net/src/smplayer/14.9.0~ds0-1/debian/repack.local/
"* Update debian/repack.local for new upstream version."
this seems to be not true.
after the previous release you added something to that file, and removed it.
Updated with lastest changes.
Looking from an external POV, the user won't notice this change, because it has
never been
part of Debian.
So please remove it (or clarify if I missed the point)
bonus point:
remove "debian/tmp" from install files.
Fixed.
(BTW I didn't try to build and run)
cheers,
Mateusz
