Bug#802633: qemu-system-x86: "GLib-WARNING" after starting qemu

[Sebastian Andrzej Siewior]

Control: tags -1 patch

On 2015-10-22 04:49:45 [+0700], Igor Liferenko wrote:
> $ qemu-system-i386 -enable-kvm -hda newimg.qcow2 -cdrom some.iso -m 256 -boot 
> once=d
> (process:11370): GLib-WARNING **: 
> /build/glib2.0-eN341t/glib2.0-2.46.0/./glib/gmem.c:482: custom memory 
> allocation vtable not supported

https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01262.html

Sebastian

diff --git a/vl.c b/vl.c
index 584ca88..6a69027 100644
--- a/vl.c
+++ b/vl.c
@@ -2719,6 +2719,7 @@ static const QEMUOption *lookup_opt(int argc, char **argv,
     return popt;
 }
 
+#if !GLIB_CHECK_VERSION(2, 44, 0)
 static gpointer malloc_and_trace(gsize n_bytes)
 {
     void *ptr = malloc(n_bytes);
@@ -2739,6 +2740,25 @@ static void free_and_trace(gpointer mem)
     free(mem);
 }
 
+static void register_glib_mem_trace_functions(void)
+{
+    GMemVTable mem_trace = {
+        .malloc = malloc_and_trace,
+        .realloc = realloc_and_trace,
+        .free = free_and_trace,
+    };
+
+    g_mem_set_vtable(&mem_trace);
+}
+#else
+static void register_glib_mem_trace_functions(void)
+{
+    /* Newer versions of glib don't support intercepting the
+     * memory allocation functions.
+     */
+}
+#endif
+
 static int machine_set_property(void *opaque,
                                 const char *name, const char *value,
                                 Error **errp)
@@ -2966,11 +2986,6 @@ int main(int argc, char **argv, char **envp)
     bool userconfig = true;
     const char *log_mask = NULL;
     const char *log_file = NULL;
-    GMemVTable mem_trace = {
-        .malloc = malloc_and_trace,
-        .realloc = realloc_and_trace,
-        .free = free_and_trace,
-    };
     const char *trace_events = NULL;
     const char *trace_file = NULL;
     ram_addr_t maxram_size;
@@ -2986,7 +3001,7 @@ int main(int argc, char **argv, char **envp)
     error_set_progname(argv[0]);
     qemu_init_exec_dir(argv[0]);
 
-    g_mem_set_vtable(&mem_trace);
+    register_glib_mem_trace_functions();
 
     module_call_init(MODULE_INIT_QOM);