[Bugfix for this issue] So, that would've been nice if this had been fixed already. I found the x >= n fix by reviewing changes between 2.13.2 and 2.14.0; perhaps not the most efficient method.
Here, I attach a debian patch, which you could plug into the series file directly and be happy. If any maintainer could drop that in and make a new release, it'd be awesome. Thanks! :) [Timidity 2.14.0] I don't immediately see why this would be blocked by the new-release bug/ticket. I tried 2.14.0, and the first thing that I noticed (apart from the fix to this bug), was this change: - pan = ((int) bank->tone[prog].pan & 0x7f); /* - 64;*/ + pan = ((int) bank->tone[prog].pan & 0x7f) - 64; That may look good in writing, but the panning comes out very differently from what I expect (and am used to with 2.13.2). There is still panning, but not at all the absolute panning (0 = 100% left, 127 = 100% right). With the changes in 2.14.0, it comes out more like 0 = a bit more left and 127 = a bit more right. I'm not sure what else 2.14.0 may be hiding, but I'm not looking for new bugs at this point. Cheers, Walter Doekes
Description: Fix a right channel crackle at start of play. Backport of: commit a2543c87bcf33d5d7a767cd88666d1102b9c18e4 Author: Keishi Suenaga <s_kei...@mutt.freemail.ne.jp> Date: Sat Jan 21 00:01:44 2006 +0000 * timidity/effect.c.orig: Noise shaping noise fix. . Reproduce with MIDI-file sample.mid: TVRoZAAAAAYAAQACAeBNVHJrAAAALAD/AxVUZXN0IHBhbm5pbmc7IHdkb2VrZXMA/1EDDe yjAP9YBAYDGAgA/y8ATVRyawAAAFYA/wMTRSwgRmlzLCBHaXMsIGxvbmctQQDAQQCwB3+y UAoAAJBAMYFugEAAArAKfwCQQjGBboBCAAKwCgAAkEQxgW6ARAACsApAAJBFMYVOgEUAAf 8vAA== . timidity sample.mid -Ow -o sample.wav . Before this patch, the right channel would produce a few random bits of noise at the start of the song. Origin: upstream, a2543c87bcf33d5d7a767cd88666d1102b9c18e4 Bug-Debian: http://bugs.debian.org/693011 Forwarded: not-needed Author: Walter Doekes <walter+deb...@wjd.nu> Index: timidity-2.13.2/timidity/effect.c =================================================================== --- timidity-2.13.2.orig/timidity/effect.c 2015-10-18 10:54:53.926732171 +0200 +++ timidity-2.13.2/timidity/effect.c 2015-10-18 10:55:21.958879741 +0200 @@ -528,7 +528,7 @@ static inline int32 my_mod(int32 x, int32 n) { - if (x > n) + if (x >= n) x -= n; return x; }
