-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Control: owner -1 ! Control: tags -1 moreinfo
> I would suggest using https in all the debian/copyright URLs. this needs to be done :) (there is an http > gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -D_FORTIFY_SOURCE=2 -g - -O2 > -Werror=array-bounds -Werror=clobbered - -Werror=volatile-register-var > -Werror=implicit-function-declaration - -fPIE -fstack-protector-strong > -Wformat -Werror=format-security -c - -o unistd.o unistd.c > unistd.c:2:0: warning: "_GL_UNISTD_INLINE" redefined #define > _GL_UNISTD_INLINE _GL_EXTERN_INLINE ^ In file included from > ../config.h:967:0, from unistd.c:1: ./unistd.h:139:0: note: this is > the location of the previous > definition > # define _GL_UNISTD_INLINE _GL_INLINE ^ > still there > ar: > > ar cru libgnu.a fd-hook.o unistd.o xsize.o asnprintf.o > printf-args.o printf-parse.o vasnprintf.o ar: `u' modifier ignored > since `D' is the default (see `U') still there > $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not > find or open any of the paths given.' [src/complexity.c:211]: > (error) Memory leak: lines_scoring [src/complexity.c:67]: (error) > va_list 'ap' was opened but not closed > by va_end(). still there (something more) Let me know how to do you want to proceed with them, and I'll followup with another review. In my opinion the define can be fixed, as well as the copyright file and the memory leak. (I didn't run the checkbashisms, codespell, lacheck, shellcheck, flawfinder tools, but I presume the errors warnings are still there). For sure you might consider forwarding typos fixes upstream. cheers, Gianfranco cheers, Gianfranco -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWDrcsAAoJEPNPCXROn13Z1JIQAKG7VZjGh8cMJw6YsPTYq1jT FGrq0jzPhVha0blXS3WRrg5JvMY/4DnpFJb3hOxCg9PIQfnf74HzvGN6qaB4lofR 1Y4I/V0Pl0zgI2ltttSu6aoKsfR8bEWQ5rp6txDQ7UZvfSJO0W5oqUHGbFXb+spF mQPYSTfoLMhIEMvUx5BX8SuVklk9PLVfgTyV5v03BRNaAd1g+7EaBdC+3C9vPNYp x501A4eWEg7AQyw6/5+ogyKH49Ss85k75iaG0X8PHlruD6bnMA/V65y2cR/MXqd+ yY/Dryks9IZvjLJuHJQGOo6BnkY8p92cJtLiwUCCbMEq7l7hkL6zBl166VyXnib7 EtkImRTGo4PmXqpg1Ux5ZqNmZr9EwcGy7ci7n/1CQL5NDbwsVRiQpUl/nfMUbBhc 9U4qKysQVUPzK/fcJ98uv2l1CeqHr0iyN6IKtkZjRqEGNNil25uVLLAKjUmPjufX NksPVrj9UCoYGsMahfW5OteKPpx6VoVLgB1xAjORIQMuZY3rAwBfB1DcIHxVhrI3 ilkZwYL+4gvL1XLc7mVi/PwL/34Yxj0XHp9SmtHTDSbpr+tSfD/8GOpC9wKuieaY E05G+Kxr2IvScz2LUxzIQ6NTzeAIOTxtyZ9NWbNVb6OQjuvrqSwncf/Adk9Jwo0f +8yg5diw+Sm1OD6yGGeb =Sb9O -----END PGP SIGNATURE-----
