Am 30.09.2015 um 16:36 schrieb Ferenc Wagner: > Michael Biebl <bi...@debian.org> writes: > >> Am 30.09.2015 um 16:04 schrieb Ferenc Wagner: >> >>> Michael Biebl <bi...@debian.org> writes: >>> >>>> Why are your using a .service file to load the dlm module? >>> >>> Sorry for being confusing by eliding too much. The dlm service starts >>> the DLM control daemon, and also loads the dlm kernel module beforehand. >>> It's dlm_controld which needs a mounted configfs (and the dlm module): >>> >>> $ systemctl cat dlm >>> # /lib/systemd/system/dlm.service >>> [Unit] >>> Description=dlm control daemon >>> Requires=corosync.service sys-kernel-config.mount >>> After=corosync.service sys-kernel-config.mount >>> >>> [Service] >>> OOMScoreAdjust=-1000 >>> Type=notify >>> NotifyAccess=main >>> EnvironmentFile=/etc/default/dlm >>> ExecStartPre=/sbin/modprobe dlm >>> ExecStart=/usr/sbin/dlm_controld --foreground $DLM_CONTROLD_OPTS >>> #ExecStopPost=/sbin/modprobe -r dlm >>> >>> # If dlm_controld doesn't stop, there are active lockspaces. >>> # Killing it will just get the node fenced. >>> SendSIGKILL=no >>> >>> [Install] >>> WantedBy=multi-user.target >>> >>>> Why does the dlm.service require the sys-kernel-config fs? >>> >>> Because dlm_controld uses files under /sys/kernel/config/dlm. >>> >>>> Can't you just ship a snippet in /usr/lib/modules-load.d/ and then also >>>> include configfs in there? >>> >>> No, loading the dlm kernel module is only part of the task. >> >> Sure, but why don't you load the dlm + configfs module not via a >> module-load.d snippet, knowing that the Debian kernel doesn't have it >> builtin? > > Do you mean I should remove the ExecStartPre directive and load dlm > (which would pull in the configfs kernel module, too) from a > module-load.d snippet?
Right, that would be my suggestion. That would work, but that would also mean > deviating from the logic used by the upstream service file. And systemd > is supposed to make distributions converge, not diverge, AFAIK. Have you asked dlm upstream, why they do it this way? Maybe they simply don't know about modules-load.d? I would in any case try to get this change upstream. Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
