Le Tue, Sep 29, 2015 at 08:38:28PM +0100, peter green a écrit : > > The attatched patch replaces a number of unaligned accesses in sam.c with > memcpy calls. It resulted in a successful build on raspbian stretch. I did > not include any conditional logic but it would be easy to add conditional > logic to only use memcpy on non-x86 targets if that was considered desirable > (I do not if memcpy is faster or slower than letting the x86 cpu fixup the > unaligned accesses in hardware and if-so whether the difference is likely to > be significant).
Thanks Peter, the upstream issue tracker already contains a pull request for alignment issues in sam.c: https://github.com/samtools/htslib/pull/99 Would you have time to see with Upstream if your patch is superior to the pull request, and if they would be willing to accept it ? Have a nice day, Charles -- Charles Plessy Debian Med packaging team, http://www.debian.org/devel/debian-med Tsurumi, Kanagawa, Japan
