Source: yoshimi
Version: 1.3.5.1-1
Tags: patch
Hi Maintainer
Please remove the unused build dependency on libjpeg9-dev from yoshimi.
It is not possible to synchronize yoshimi directly into Ubuntu as
libjpeg9-dev does not exist there.
In Debian and Ubuntu the libjpeg build dependency should be unversioned,
i.e. libjpeg-dev, see [1] [2].
However, since yoshimi does not need this build dependency, it can be
removed altogether.
While looking at the packaging, I noticed the following line in
debian/rules:
LDFLAGS+=-Wl,--as-needed
This has no effect. What you want is this (see [3]):
export DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed
Lastly, the generated file src/version.txt is not removed after
building, this prevents the package from being built twice in a row.
Please see the attached patch that makes all of these changes.
Regards
Graham
[1] https://wiki.debian.org/LJTTransition
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717076#235
[3] https://wiki.debian.org/HardeningWalkthrough#debhelper_9
diff -Nru yoshimi-1.3.6/debian/clean yoshimi-1.3.6/debian/clean
--- yoshimi-1.3.6/debian/clean 1970-01-01 02:00:00.000000000 +0200
+++ yoshimi-1.3.6/debian/clean 2015-09-29 17:58:43.000000000 +0200
@@ -0,0 +1 @@
+src/version.txt
diff -Nru yoshimi-1.3.6/debian/control yoshimi-1.3.6/debian/control
--- yoshimi-1.3.6/debian/control 2015-07-01 07:56:25.000000000 +0200
+++ yoshimi-1.3.6/debian/control 2015-09-29 17:34:10.000000000 +0200
@@ -25,7 +25,6 @@
libcairo2-dev,
sharutils,
lv2-dev,
- libjpeg9-dev,
libxft-dev
Standards-Version: 3.9.6
Vcs-Git: git://anonscm.debian.org/pkg-multimedia/yoshimi.git
diff -Nru yoshimi-1.3.6/debian/rules yoshimi-1.3.6/debian/rules
--- yoshimi-1.3.6/debian/rules 2015-05-10 21:30:03.000000000 +0200
+++ yoshimi-1.3.6/debian/rules 2015-09-29 18:00:41.000000000 +0200
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
-LDFLAGS+=-Wl,--as-needed
+export DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed
ifneq (,$(findstring :$(DEB_HOST_ARCH_CPU):,:amd64:))
CXXFLAGS+=-msse -msse2 -mfpmath=sse
