On Sat, Dec 31, 2005 at 02:47:57PM +0100, Maximilian Attems wrote:
> On Sat, Dec 31, 2005 at 07:16:24AM -0500, Todd Troxell wrote:
> > On Fri, Dec 23, 2005 at 08:21:53PM +0200, Markus Peuhkuri wrote:
> > > Package: logcheck
> > > Version: 1.2.42
> > > Severity: minor
> > > Tags: patch
> > > 
> > > Logcheck does not report any error if the config file is not readable
> > > or does not exists.  This may easily happen, as logcheck is run as
> > > logcheck user and while one is testing a new configuration on live
> > > system with running configuration intact.
> > > 
> > > Following fragment may help:
> > > 
> > >  # Now source the config file - before things that should not be changed
> > >  if [ -r $CONFFILE ]; then
> > > -       . $CONFFILE
> > > +       . $CONFFILE
> > > +else
> > > +    error "Config file $CONFFILE not exists or readable"
> > >  fi
> > 
> > The patch is greatly appreciated.  Thanks, Markus. Your change will be in 
> > the
> > next release.
> > 
> > -- 
> > Todd Troxell
> > http://rapidpacket.com/~xtat
> 
> i'm less then sure that this the right way to go,
> we shouldn't need the $CONFFILE?

I see your point.  The config is not really essential.

What do you think about this:

if [ -f $CONFFILE -a -r $CONFFILE]; then

> ps sorry for my inactivity lately most time was gobbed by
> initramfs-tools and klibc.
> will get more active next week again, have an c rewritten logtail
> in the pipe.

No worries!  The initial benchmarks looked pretty sweet :)

-- 
Todd Troxell
http://rapidpacket.com/~xtat


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to