Please find, for review, the debconf templates and packages descriptions for the open-iscsi source package.
This review will last from Friday, September 11, 2015 to Monday, September 21,
2015.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.
Rationale:
--- open-iscsi.old/debian/open-iscsi.templates 2015-09-03 07:12:44.672751389
+0200
+++ open-iscsi/debian/open-iscsi.templates 2015-09-11 07:08:21.561599260
+0200
@@ -1,49 +1,53 @@
Template: open-iscsi/remove_even_with_active_sessions
Type: boolean
+#flag:translate!:6,8
_Description: Do you want to proceed with removing open-iscsi?
There are currently active iSCSI sessions. If you remove open-iscsi
now this may lead to data loss and/or hang your system at shutdown.
.
- DO NOT DO THIS IF YOUR ROOT FILESYSTEM IS ON ISCSI!
+ Do not do do this is this system's root filesystem is on iSCSI.
Though I very much understand the will to warn users, we ALWAYS
discourage using all caps.
Also avoid "your filesystem". Why should it be "mine"? ;-)
.
If you do proceed, open-iscsi will try to unmount all filesystems on
iSCSI and logout from current sessions. If that fails (because a
- filesystem is still in use), the kernel will keep open the current
- iSCSI sessions, but not perform any recovery in case there is an
- interruption of the network connection (or the target is rebooted
- etc.).
+ filesystem is still in use), the kernel will keep the current
+ iSCSI sessions opened, but will not perform any recovery in case there is an
+ interruption of the network connection (or if the target is rebooted).
+ .
+ If you really want to remove open-iscsi, you should abort here
+ and stop open-iscsi:
I left the "if you do proceed" as, IIRC, this is meant to emphasize
that it's probably not a good idea, but I'd like to get Justin's input
on this.
s/open/opened
Dropped the "etc." that doesn't seem useful. If there are other
reasons, then they should be listed.
.
- If you really want to remove open-iscsi, it is advisable to abort here
- and to first stop open-iscsi:
service open-iscsi stop
+ .
If that did not clean up everything, manually umount all filesystems
that are on iSCSI, manually dismantle the storage stack and only then
logout from all iSCSI sessions:
+ .
iscsiadm -m node --logoutall=all
+ .
At that point, it should be safe to remove this package.
Put the untranslatable strings alone and mark them untranslatable
(hence the "#flag" line in the template's header).
Template: open-iscsi/upgrade_even_with_failed_sessions
Type: boolean
_Description: Do you want to proceed with upgrading open-iscsi?
- There are currently failed iSCSI sessions. Upgrading open-iscsi MAY
+ There are currently failed iSCSI sessions. Upgrading open-iscsi may
cause data loss.
Drop useless yelling
.
If you do not proceed, the preinstallation script will be aborted and
you will have the option to manually recover the iSCSI sessions. (Note
that aborting an upgrade is problematic if you are dist-upgrading your
entire system.) You may also recover the iSCSI sessions manually while
- keeping this prompt open and then choose to proceed. Or you may choose
+ keeping this prompt opened and then choose to proceed. Or you may choose
to proceed directly, after which iscsid will be restarted and session
recovery will be attempted once more.
Template: open-iscsi/upgrade_recovery_error
-Type: note
+Type: error
That note is rather "error" than "note"
_Description: iSCSI recovery error on upgrade
- iscsid was restarted, but couldn't recover all iSCSI sessions. This is
- bad and could lead to DATA LOSS. Please check your system and kernel
+ The iscsid daemon was restarted, but couldn't recover all iSCSI sessions.
This is
+ bad and could lead to data loss. Please check the system and kernel
logs to determine the cause of the issue.
.
- Please DO NOT acknowledge this note until you have fixed the problem
+ Please do not acknowledge this note until you have fixed the problem
from a separate login shell.
"The <foo> daemon" is our usual trick to avoid the problem having a
lowercase letter at the beginning of a sentence.
Drop yelling
Template: open-iscsi/downgrade_and_break_system
@@ -51,7 +55,7 @@
_Description: Do you really want to downgrade open-iscsi?
You are trying to downgrade open-iscsi. Because of changes between the
version you are downgrading to and the version currently installed,
- this downgrade WILL BREAK YOUR SYSTEM.
+ this downgrade will break the system.
.
If you really want to downgrade, please follow the following procedure
instead: umount all iSCSI file systems, log out of all iSCSI sessions,
And again (and s/your/the)
--
Template: open-iscsi/remove_even_with_active_sessions Type: boolean #flag:translate!:6,8 _Description: Do you want to proceed with removing open-iscsi? There are currently active iSCSI sessions. If you remove open-iscsi now this may lead to data loss and/or hang your system at shutdown. . Do not do do this is this system's root filesystem is on iSCSI. . If you do proceed, open-iscsi will try to unmount all filesystems on iSCSI and logout from current sessions. If that fails (because a filesystem is still in use), the kernel will keep the current iSCSI sessions opened, but will not perform any recovery in case there is an interruption of the network connection (or if the target is rebooted). . If you really want to remove open-iscsi, you should abort here and stop open-iscsi: . service open-iscsi stop . If that did not clean up everything, manually umount all filesystems that are on iSCSI, manually dismantle the storage stack and only then logout from all iSCSI sessions: . iscsiadm -m node --logoutall=all . At that point, it should be safe to remove this package. Template: open-iscsi/upgrade_even_with_failed_sessions Type: boolean _Description: Do you want to proceed with upgrading open-iscsi? There are currently failed iSCSI sessions. Upgrading open-iscsi may cause data loss. . If you do not proceed, the preinstallation script will be aborted and you will have the option to manually recover the iSCSI sessions. (Note that aborting an upgrade is problematic if you are dist-upgrading your entire system.) You may also recover the iSCSI sessions manually while keeping this prompt opened and then choose to proceed. Or you may choose to proceed directly, after which iscsid will be restarted and session recovery will be attempted once more. Template: open-iscsi/upgrade_recovery_error Type: error _Description: iSCSI recovery error on upgrade The iscsid daemon was restarted, but couldn't recover all iSCSI sessions. This is bad and could lead to data loss. Please check the system and kernel logs to determine the cause of the issue. . Please do not acknowledge this note until you have fixed the problem from a separate login shell. Template: open-iscsi/downgrade_and_break_system Type: boolean _Description: Do you really want to downgrade open-iscsi? You are trying to downgrade open-iscsi. Because of changes between the version you are downgrading to and the version currently installed, this downgrade will break the system. . If you really want to downgrade, please follow the following procedure instead: umount all iSCSI file systems, log out of all iSCSI sessions, back up /etc/iscsi, purge open-iscsi and reinstall the older version.
--- open-iscsi.old/debian/open-iscsi.templates 2015-09-03 07:12:44.672751389
+0200
+++ open-iscsi/debian/open-iscsi.templates 2015-09-11 07:08:21.561599260
+0200
@@ -1,49 +1,53 @@
Template: open-iscsi/remove_even_with_active_sessions
Type: boolean
+#flag:translate!:6,8
_Description: Do you want to proceed with removing open-iscsi?
There are currently active iSCSI sessions. If you remove open-iscsi
now this may lead to data loss and/or hang your system at shutdown.
.
- DO NOT DO THIS IF YOUR ROOT FILESYSTEM IS ON ISCSI!
+ Do not do do this is this system's root filesystem is on iSCSI.
.
If you do proceed, open-iscsi will try to unmount all filesystems on
iSCSI and logout from current sessions. If that fails (because a
- filesystem is still in use), the kernel will keep open the current
- iSCSI sessions, but not perform any recovery in case there is an
- interruption of the network connection (or the target is rebooted
- etc.).
+ filesystem is still in use), the kernel will keep the current
+ iSCSI sessions opened, but will not perform any recovery in case there is an
+ interruption of the network connection (or if the target is rebooted).
+ .
+ If you really want to remove open-iscsi, you should abort here
+ and stop open-iscsi:
.
- If you really want to remove open-iscsi, it is advisable to abort here
- and to first stop open-iscsi:
service open-iscsi stop
+ .
If that did not clean up everything, manually umount all filesystems
that are on iSCSI, manually dismantle the storage stack and only then
logout from all iSCSI sessions:
+ .
iscsiadm -m node --logoutall=all
+ .
At that point, it should be safe to remove this package.
Template: open-iscsi/upgrade_even_with_failed_sessions
Type: boolean
_Description: Do you want to proceed with upgrading open-iscsi?
- There are currently failed iSCSI sessions. Upgrading open-iscsi MAY
+ There are currently failed iSCSI sessions. Upgrading open-iscsi may
cause data loss.
.
If you do not proceed, the preinstallation script will be aborted and
you will have the option to manually recover the iSCSI sessions. (Note
that aborting an upgrade is problematic if you are dist-upgrading your
entire system.) You may also recover the iSCSI sessions manually while
- keeping this prompt open and then choose to proceed. Or you may choose
+ keeping this prompt opened and then choose to proceed. Or you may choose
to proceed directly, after which iscsid will be restarted and session
recovery will be attempted once more.
Template: open-iscsi/upgrade_recovery_error
-Type: note
+Type: error
_Description: iSCSI recovery error on upgrade
- iscsid was restarted, but couldn't recover all iSCSI sessions. This is
- bad and could lead to DATA LOSS. Please check your system and kernel
+ The iscsid daemon was restarted, but couldn't recover all iSCSI sessions.
This is
+ bad and could lead to data loss. Please check the system and kernel
logs to determine the cause of the issue.
.
- Please DO NOT acknowledge this note until you have fixed the problem
+ Please do not acknowledge this note until you have fixed the problem
from a separate login shell.
Template: open-iscsi/downgrade_and_break_system
@@ -51,7 +55,7 @@
_Description: Do you really want to downgrade open-iscsi?
You are trying to downgrade open-iscsi. Because of changes between the
version you are downgrading to and the version currently installed,
- this downgrade WILL BREAK YOUR SYSTEM.
+ this downgrade will break the system.
.
If you really want to downgrade, please follow the following procedure
instead: umount all iSCSI file systems, log out of all iSCSI sessions,
Source: open-iscsi Section: net Priority: optional Maintainer: Debian iSCSI Maintainers <pkg-iscsi-maintain...@lists.alioth.debian.org> Uploaders: Ritesh Raj Sarraf <r...@debian.org>, Christian Seiler <christ...@iwakd.de> Build-Depends: debhelper (>= 9), bzip2, bison, flex, autotools-dev, dh-autoreconf, dh-exec, dpkg-dev (>= 1.16.1~), po-debconf, dh-systemd Standards-Version: 3.9.6 Vcs-Git: git://anonscm.debian.org/pkg-iscsi/open-iscsi.git Vcs-Browser: http://anonscm.debian.org/gitweb/?p=pkg-iscsi/open-iscsi.git Homepage: http://www.open-iscsi.org/ Package: open-iscsi Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, udev Pre-Depends: debconf | debconf-2.0 Description: High performance, transport independent iSCSI implementation Open-iSCSI is a high-performance, transport independent, multi-platform implementation of RFC3720 iSCSI . Open-iSCSI is partitioned into user and kernel parts where the kernel portion implements iSCSI data path (i.e. iSCSI Read and iSCSI Write) The userspace contains the entire control plane consisting of: * Configuration Manager * iSCSI Discovery, Login and Logout processing * Connection level error processing * Nop-In and Nop-Out handling * Text processing, iSNS, SLP, Radius et cetera (future) . The userspace component consists of a daemon, iscsid and a management utility, iscsiadm Package: open-iscsi-udeb # Note: the (virtual) udeb package scsi-modules (provided by different # linux kernel udebs) must exist for these architectures - so # check that before adding them to this list; the other # scsi-(core|common|...)-modules are NOT sufficient! Architecture: amd64 arm64 i386 ia64 mips mipsel powerpc s390x ppc64el ppc64 armhf Section: debian-installer Package-Type: udeb Depends: ${shlibs:Depends}, ${misc:Depends}, scsi-modules, libnss-files-udeb Description: Configure iSCSI Open-iSCSI is a high-performance, transport independent, multi-platform implementation of RFC3720 iSCSI. . This is the minimal package (udeb) used by debian-installer. #Package: linux-iscsi-modules-source #Architecture: all #Depends: ${shlibs:Depends}, ${misc:Depends}, module-assistant, debhelper (>= 4.0.0), bzip2 #Description: Source Code for the Linux iSCSI Kernel Modules # Along with make-kpkg, this package maybe used to build a linux-iscsi-modules # package for a kernel-image package.
signature.asc
Description: Digital signature
