Source: abi-compliance-checker
Version: 1.99.9-2
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps umask toolchain
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Hi,

While working on the "reproducible builds" effort [0], we have noticed
that abi-compliance-checker generates .abi.tar.gz files that are not
reproducible.

The attached patch fixes the umask and the timestamps of the files
inside the tarball. Once, abi-compliance-checker can be built
reproducibly
in our reproducible toolchain.

 [0] https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-
diff --git a/abi-compliance-checker.pl b/abi-compliance-checker.pl
index 6593237..46309e7 100755
--- a/abi-compliance-checker.pl
+++ b/abi-compliance-checker.pl
@@ -21960,6 +21960,10 @@ sub create_ABI_Dump()
         open(DUMP, ">", $DPath) || die ("can't open file \'$DPath\': $!\n");
         print DUMP $ABI_DUMP;
         close(DUMP);
+
+        # Ensure contents of archive have deterministic contents
+        chmod(0644, $DPath);
+        utime(0, 0, $DPath);
         
         if(not -s $DPath) {
             exitStatus("Error", "can't create ABI dump because something is 
going wrong with the Data::Dumper module");

Reply via email to