Hi Gianfranco Costamagna, On Fri, 2015-09-04 at 17:04 +0000, Gianfranco Costamagna wrote: > if they aren't called by standard dh calls it is fine to keep them there. > > maybe just move to the bottom, (I think they are already there)
I will keep those custom target in the bottom of d/rules.
Yes, all of custom-target-related lines had been already
clustered at the bottom of d/rules, and I have drew a big
split line at the beginning of them, in the updated version.
> well, they aren't called by buildd systems, so I don't care.
>
> Users who apt-get source your package should also know how to build
> the custom stuff.
The custom stuff is explained in the README.Debian, and it
in fact includes a custom compile guide and some more other
things.
> I guess you already did it correctly.
>
> I like this version more than the previous one (note, I didn't test a build)
>
> anyway:
> please add gcc/g++ 4.9 or whatever to the b-d in control file. It is not
> guarantee
> specially after the gcc-5 switch that they will be there.
I have added g{cc,++}-4.9 in the updated d/control, so this package
won't FTBFS due to dependency bump of build-essential to gcc5.
However if CUDA/experimental is an updated version (7.0),
gcc5 should be able to work.
(I successfully built Caffe on ArchLinux + CUDA 7 + gcc 5)
> to see if nvidia is available (amd or i386 I would do something like:
>
> In rules file, to see
> ifeq ($(shell dpkg-query --status nvidia-cuda-toolkit |grep -o Package),
> Package)
>
> flag_build_caffe_cuda := y
>
> endif
I think this is better than above:
19 ifeq (installed, $(shell dpkg -s nvidia-cuda-toolkit | grep -o installed))
20 flag_build_caffe_cuda := y
21 endif
then we can make sure nvidia-cuda-toolkit is "installed" on
system rather than "residual-config" or something else.
Thank you for this trick and it looks cool.
:-)
> this way you avoid a double "if" and if tomorrow cuda gets another arch
> support, you just need
> to add it in the control file.
Thanks.
signature.asc
Description: This is a digitally signed message part
