On Thu, Aug 27, 2015 at 06:14:33PM +0900, Osamu Aoki wrote:
> Hi,
>
> On Wed, Aug 26, 2015 at 10:07:28PM -0400, James McCoy wrote:
> > On Thu, Aug 27, 2015 at 12:00:50AM +0900, Osamu Aoki wrote:
> ...
> > > + if (defined $options{'repacksuffix'}) {
> > > + # assume it was repacked (if wasn't, remove opts=repacksuffix in
> > > watchfile)
> >
> > There shouldn't be a need to assume. $repack is set if a repack was
> > requested, so an adjustment should be moved into the previous if block
> > (which is what calls mk-origtargz).
>
> That is what I initially thought ... but not quite so.
>
> The --repack-suffix produces conditional repack/rename results without
> --repack.
>
> There is a case where repack happens without explicit --repack option.
Yes, but mk-origtargz is only called in that block, so there's no need
to set the suffix unless that block is executed.
Also, we're already parsing information about mk-origtargz's output, so
why shouldn't that be used to appropriately set the the new filename in
uscan?
Cheers,
--
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <james...@debian.org>
