Control: tag -1 - patch
Hi,
Nicolas Braud-Santoni wrote (21 Aug 2015 15:24:44 GMT) :
> Please find enclosed a patch which adds a AppArmor profile for the
> haveged package.
Yay, thanks :)
A few questions:
* Was this tested on current sid with systemd as pid 1? (that's
a must)
* Was this tested on Ubuntu? (nice to have, not a must)
> +/usr/sbin/haveged {
> + #include <abstractions/base>
> + #include <local/usr.sbin.haveged>
Please move the "local" line to the end of the profile, for
consistency with how all other profiles do it (also, I suspect this
allows overriding some default settings).
Otherwise, sounds great! I don't remember if you've already sent this
to the AppArmor upstream mailing-list for review. Did you?
That's a great and friendly place, where you'll get feedback from
people who are way more skilled than I am :)
Dropping the "patch" tag until these are clarified.
Cheers,
--
intrigeri
