Control: reopen -1

On Sun, Jul 12, 2015 at 09:39:11PM +0000, Debian Bug Tracking System wrote:
> This is an automatic notification regarding your Bug report
> which was filed against the src:dh-make-perl package:
> 
> #789729: dh-make-perl: FTBFS with perl 5.22: test failures
> 
> It has been closed by Damyan Ivanov <d...@debian.org>.

Hi Damyan,

Unfortunately this doesn't seem quite right:

#   Failed test 'Errno is in perl-base'
#   at t/DpkgLists.t line 33.
#     Structures begin differing at:
#          $got->[0] = 'libperl5.22:amd64'
#     $expected->[0] = 'libperl5.22:amd64
#     '

#   Failed test 'IO::Socket::UNIX is in perl-base'
#   at t/DpkgLists.t line 39.
#     Structures begin differing at:
#          $got->[0] = 'libperl5.22:amd64'
#     $expected->[0] = 'libperl5.22:amd64
#     '
# Looks like you failed 2 tests of 7.
t/DpkgLists.t ....................... 
1..7
ok 1 - use Debian::DpkgLists;
ok 2 - /usr/bin/perl is in perl-base
ok 3 - partial /bin/perl is in perl-base
ok 4 - qr{/bin/perl$} is in perl-base
not ok 5 - Errno is in perl-base
not ok 6 - IO::Socket::UNIX is in perl-base
ok 7 - utf8 is in perl-base
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/7 subtests 

Presumably a chomp is in order...

Cheers,
Dominic.
>From bf3d58fbb23a69ea7e59c143663d2530af499b90 Mon Sep 17 00:00:00 2001
From: Dominic Hargreaves <d...@earth.li>
Date: Thu, 27 Aug 2015 22:38:32 +0100
Subject: [PATCH] Really fix t/DpkgLists.t to support perl 5.22

---
 t/DpkgLists.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/DpkgLists.t b/t/DpkgLists.t
index 951ad95..1910873 100755
--- a/t/DpkgLists.t
+++ b/t/DpkgLists.t
@@ -14,7 +14,7 @@ my $m = 'Debian::DpkgLists';
 
 my $perl_api = $Config{PERL_API_REVISION}.'.'.$Config{PERL_API_VERSION};
 
-my $arch = `dpkg-architecture -q DEB_HOST_ARCH`;
+chomp (my $arch = `dpkg-architecture -q DEB_HOST_ARCH`);
 
 my $pkg_perl_modules = "perl-modules-$perl_api";
 my $pkg_libperl = "libperl$perl_api:$arch";
-- 
2.1.4

Reply via email to