2015-08-16 23:56 GMT+08:00, Jakub Wilk <jw...@debian.org>: > * Alex Vong <alexvong1...@gmail.com>, 2015-08-16, 19:42: >>http://mentors.debian.net/debian/pool/main/m/mlucas/mlucas_14.1-dfsg1.dsc > > I don't intend to sponsor this package, but I had a quick look at it: > Thanks for the quick look!
> Don't assume that kfreebsd-any means only kfreebsd-i386 and > kfreebsd-amd64. It is the case for the moment, but it might be in the > future. > Yes, I do not use the `all' wildcard in the first place is because mlucas uses a lot of platform-dependent code. It probably won't work for the new kfreebsd-* in the future unless new CPU types are added. > "dfsg" should be a suffix to upstream version, not a prefix to Debian > revision. In other words, the version should be something like: > 14.1+dfsg-1 > I see, so `dfsg' is NOT part of upstream version. I was not paying attention to this. > "Welcome to ..." is not something I'd write in a package description. > Let me think for a while on how to change this. > You could reduce size of .orig.tar by ~60% by using xz compression. > Never try this before, will try now. > You are not supposed to set DEB_BUILD_OPTIONS in debian/rules. > You should honour the options set by the user instead. > Let me remove it then. > Typos (most detected by codespell or spellintian): > > $HOME/mlucas.d/ -> $HOME/.mlucas.d/ > ]nto -> into > accomodate -> accommodate > adn -> and > assigment -> assignment > attept -> attempt > begining -> beginning > correponds -> corresponds > defintion -> definition > differnt -> different > fucntion -> function > garantee -> guarantee > implemetation -> implementation > indicies -> indices > occured -> occurred > overriden -> overridden > sucess -> success > thru -> through > usefull -> useful > whn -> when > Never used spell-checking before but I know how to use codespell now. > -- > Jakub Wilk > > Cheers, Alex
