Bug#794996: [Pkg-openldap-devel] Bug#794996: openldap: patches for slapd.scripts-common

[Ryan Tandy]

Hi Peter,

Thanks for the patches!

On Sun, Aug 09, 2015 at 09:19:39AM +0200, Peter Marschall wrote:

* 0001-slapd.scripts-common-bring-together-comment-and-comm.patch
 slapd.scripts-common: bring together comment and commented code

http://anonscm.debian.org/viewvc/pkg-openldap/openldap/trunk/debian/slapd.scripts-common?r1=670&r2=671#h551

The origins are even older:

http://anonscm.debian.org/viewvc/pkg-openldap/people/torsten/openldap2.2/debian/slapd.postinst?r1=407&r2=408&pathrev=469

http://anonscm.debian.org/viewvc/pkg-openldap/people/torsten/openldap2.2/debian/slapd.postinst?r1=201&r2=202&pathrev=469#h103

Deleted the comment instead.

I don't think that comment actually applies to the code below it, but to some previously commented-out code that has since been removed:

* 0002-slapd.scripts-common-use-update_permissions-instead-.patch
 Use use update_permissions instead direct calls to chown & chgrp

Applied.

* 0003-slapd.scripts-common-fix-permissions-when-migrating-.patch
 Add a update_permissions that may have been forgotten

I don't see the point of this one. At this point the directory is empty; the contents are loaded after (operating as root, not as openldap); and the permissions are fixed up after the work is completed, at the end of postinst_upgrade_configuration. What's your reasoning?

* 0004-slapd.scripts-common-local-ize-variables.patch
 Use local bash variables where possible.

Applied.

* 0005-slapd.scripts-common-restore-by-increasing-suffix-pa.patch
 slapd.scripts-common: restore by increasing suffix path length

 This should help configurations with databases glued together using the
 'subordinate' keyword / 'olcSubordinate' attribute in slapd's configuration.

Applied.



thanks,
Ryan

I synthesized changelog entries paraphrasing your remarks; hope the result is OK.

signature.asc
Description: Digital signature