> On Mon, 08 Jun 2015, Raphael Hertzog wrote: > > we just tried the trunk. It's better but there are still multiple > > problems: > > - LDFLAGS is not used when you link the executables (it's only used when > > you link libregfi) > > - the default value for LDFLAGS is wrong, "-z relro" is an option for "ld" > > but > > when you pass it through gcc you need "-Wl,-z,relro" > > - I saw you tried to hack up some code to setup the SONAME... it does set > > the SONAME on the library but the library is still installed under the > > wrong name (libregfi.so instead of the name set in the SONAME) > > - the SONAME must not encode the full version... it's only a simple > > counter of API/ABI compatibility. Please use "libregfi.so.0" as > > the first SONAME (and then bump to libregfi.so.1 when you break > > the ABI/API, etc.) (and 99.99.99.X looks really wrong as a version number > > :)) > > Tim, I hope you can fix those issues quickly now that we have identified > how to properly handle versioned libraries and that you can make a new > release.
Hi Raphael, I finally had a chance to take another crack at this. I've attempted to address all of the items listed above. I integrated your guys' soname patch and tweaked it a bit to use a partial reglookup version number as the ABI version. The way it behaves right now is to assign "1.0.1" as the version when working from trunk. When working from a release version, it will use just the first two portions of the version (e.g. "1.0"). The reason for this is that I don't change my API in minor point releases, but I typically do when the upper version numbers change. I did not integrate the other patch that strips python installs, since users need that if they compile from source. Can you simply run these two targest to achieve the same result? scons install_bin scons install_lib I fixed the two LDFLAGS issues you pointed out as well. Let me know if you think it is up to snuff now. Best, tim -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
