On Thu, Nov 10, 2005 at 11:49:50AM +0000, Martin Michlmayr wrote: > Anyway, I looked at the code to see how this can be implemented... I > noticed there's a -R/--rename option but this code is really a > mess: -R doesn't actually do anything at all. And the internal > freedb_rename variable (which has nothing to do with -R) is completely > useless too: jack tries to do renames even when you don't use -Q/-q at > all (i.e. just 'jack -t 1') and then fails:
In my experience, using -R has its uses, namely if you modify jack.freedb and want to rename/retag the files without querying freedb.org again, and it seems to work mostly fine for me usually. Maybe you are talking about a more specific use case though, I did not look at the code either. > I tried to clean up the code, and I introduced a --dont-rename > variable. In the patch, I got rid of all the freedb_rename variables > (which don't actually do anything), got rid of -R/--rename (which > again, doesn't do anything, and doesn't make sense since -Q/-q > automatically renames). Does -Q/-q recognize whether the computer is online and/or fail gracefully if not these days? > I won't apply this to the Debian package for now since I'd ideally > like to hear comments from upstream. In particular, I'm not sure if > --dont-rename is such a good name but --rename=no doesn't seem good to > me either given that --rename=yes doesn't actually do anything (it's > implied by -Q/-q anyway). > > Philipp, feel free to apply this patch though and let me know if this > is what you want. Oh, by the way, even with --dont-rename, > directories *are* renamed. This is because there's another option to > stop this: --rename-dir=bool Hmm, looking at this, maybe the > --dont-rename option should be called --rename-files=bool after all. > Arne/Michael, what do you think? Does it make sense to not rename directories while renaming files, or vice-versa? I think the underlying problem is that --rename really is not much of an option (I mean, if you queried and now have an freedb entry available, why wouldn't you want to have your files renamed?) but rather an action (which is, granted, executed automatically most of the time). IMO, jack -R should neither try to rip, encode nor query (regardless of what other options are set), but just rename the directories and rename/tag the files, if the jack.freedb file got changed since the last progress (or maybe always, dunno). One could argue that jack should optionally try to query if only the default jack.freedb is around, this could be an option, like jack -R --query=no. One way out of this (or maybe I'm trying to solve a problem which isn't there, correct me if I'm wrong) would be to have a couple of different executables which do several actions: jack-rip, jack-query, jack-tag (where the last implies renaming and tagging). The regular jack would be a "just works, do whatever needs to be done for the current CD/directory", while the others just do their job, regardless of the respective options like query_on_start or rename_dirs. Another option would be to better destinguish between actions and options, if possible. What do you think? Michael -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
