Package: tmate Version: 1.8.10-1 Severity: normal Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu wily ubuntu-patch
Dear Maintainer, We use ld --as-needed in Ubuntu, and your package currently fails to build from source there due to using LDFLAGS instead of LDADD for libraries. In Ubuntu, the attached patch was applied to achieve the following: * Use tmate_LDADD instead of tmate_LDFLAGS to fix FTBFS with ld --as-needed. Thanks for considering the patch. Logan Rosen -- System Information: Debian Release: jessie/sid APT prefers trusty-updates APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500, 'trusty'), (100, 'trusty-backports') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.8.0-36-generic (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
diff -Nru tmate-1.8.10/debian/patches/01_dont-use-embedded-libraries.patch tmate-1.8.10/debian/patches/01_dont-use-embedded-libraries.patch --- tmate-1.8.10/debian/patches/01_dont-use-embedded-libraries.patch 2015-07-17 17:36:38.000000000 -0400 +++ tmate-1.8.10/debian/patches/01_dont-use-embedded-libraries.patch 2015-07-26 00:47:29.000000000 -0400 @@ -1,6 +1,8 @@ ---- a/Makefile.am -+++ b/Makefile.am -@@ -22,7 +22,6 @@ CFLAGS += -D_GNU_SOURCE +Index: tmate-1.8.10/Makefile.am +=================================================================== +--- tmate-1.8.10.orig/Makefile.am 2015-07-26 00:34:30.320880936 -0400 ++++ tmate-1.8.10/Makefile.am 2015-07-26 00:47:27.068880936 -0400 +@@ -24,7 +24,6 @@ endif CFLAGS += -Wno-unused-parameter -Wno-unused-variable @@ -8,16 +10,15 @@ CFLAGS += -rdynamic # for stack traces # Set flags for gcc. gcc4 whines abouts silly stuff so it needs slightly -@@ -242,18 +241,6 @@ if NO_B64_NTOP +@@ -244,18 +243,4 @@ nodist_tmate_SOURCES += compat/b64_ntop.c endif -tmate_LDADD = \ - libssh/build/src/libssh.a \ - msgpack/src/.libs/libmsgpackc.a -+tmate_LDFLAGS = -lssh -lmsgpack - - *.c: $(tmate_LDADD) +- +-*.c: $(tmate_LDADD) - -libssh/build/src/libssh.a: - cd libssh/build; ([ -f Makefile ] || cmake .. -DWITH_SFTP=OFF -DWITH_SERVER=OFF -DWITH_PCAP=OFF -DWITH_STATIC_LIB=ON -DWITH_GSSAPI=OFF) @@ -28,3 +29,4 @@ - +make -C msgpack/src libmsgpackc.la - -.PHONY: libssh/build/src/libssh.a msgpack/src/.libs/libmsgpackc.a ++tmate_LDADD = -lssh -lmsgpack
