On 07/13/2015 09:24 AM, Swann Croiset wrote:
> On Thu, Jul 9, 2015 at 3:55 AM, Swann Croiset <sw...@oopss.org
> <mailto:sw...@oopss.org>> wrote:
>
> Package: influxdb-python
> Version: 0.1.12-1
> Severity: wishlist
>
> Dear Maintainer,
>
> I need the last version of this package, can you upload it. If you don't
> have time please let me know. I can make it as a NMU.
>
> Thanks
>
> Hello,
>
> I have updated the repo on the Alioth repository.
>
> Can you upload it? I am not a DD
>
> http://anonscm.debian.org/cgit/collab-maint/influxdb-python.git
>
>
>
> Alexandre Viau
> alexan...@alexandreviau.net <mailto:alexan...@alexandreviau.net>
Hi Alexandre,
My colleague Swann isn't a DD either, but I am, and I can sponsor your
package. There's however a few issues that needs to be corrected. Let me
go through them.
debian/changelog
================
Version 0.1.13-1 was never uploaded to Debian. Please remove that from
the changelog.
Git repository
==============
You haven't uploaded the version 2.6.0 in the pristine-tar branch.
After downloading the tarball from github, I couldn't build, as there's
differences with upstream tarball
debian/control
==============
There's already version 2.7 only and version 3.4 of Python in Debian
Jessie, so we don't need X-Python-Version: >= 2.7 X-Python3-Version: >=
3.3 (they make no sense). Please remove them, or at least upgrade them
to the current Python version.
Lots of packages could go to Build-Depends-Indep:. More over, the
package declares it needs six == 1.9.0, so you should translate this
into >= 1.9.0. Here's the list, how I would write it:
Build-Depends: debhelper (>= 9),
dh-python,
python-all,
python-setuptools,
python3-all,
python3-setuptools,
Build-Depends-Indep: python-requests (>= 1.0.3),
python-mock,
python-requests-mock (>= 0.5.1),
python-six (>= 0.1.9),
python-nose,
python-pandas,
python3-requests,
python3-mock,
python3-requests-mock (>= 0.5.1),
python3-six (>= 0.1.9),
python3-nose,
python3-pandas
The rule here is that anything which isn't needed for the clean target
can be put in Build-Depends-Indep.
Also, since you aren't running unit tests, are you sure you need all of
the above for building?
The Depends: for six should also have a minimum version.
Also, you should review both the long and short description. There's no
need to add "Python" in the short description, as this is already in the
package name. The long description is a way too short. It should be made
of at least 3 lines, and here, it contains no information but the fact
the package is for Python 2 or 3. If you have nothing to tell about this
client, just write about InfluxDB itself.
Others
======
When rebuilding the package twice, the egg-info appears in the diff, so
the package can't be built. Please add this in debian/source/options to
fix the issue:
extend-diff-ignore = "^[^/]*[.]egg-info/"
Please correct the above issues, and reupload to collab-maint, then I'll
review the package and hopefully sponsor it.
Cheers,
Thomas Goirand (zigo)
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
