Control: reassign 791535 dpkg-dev
Control: forcemerge 790073 791535

Hi!

On Mon, 2015-07-06 at 20:49:52 +0200, Guillem Jover wrote:
> On Fri, 2015-06-26 at 15:55:49 -0400, Aaron M. Ucko wrote:
> > Package: dpkg-dev
> > Version: 1.18.1
> > Severity: important

> > When unpacking a .debian tarball, dpkg-source explicitly excludes any
> > files that were already in the corresponding .orig tarball, which in
> > some cases can yield excessively long command lines.  In particular,
> > this approach makes it impossible to unpack emoslib on kFreeBSD:
> > 
> > dpkg-source: info: unpacking emoslib_4.0.3+dfsg.1.orig.tar.xz
> > dpkg-source: info: unpacking emoslib_4.0.3+dfsg.1-1.debian.tar.xz
> > Can't exec "tar": Argument list too long at /usr/share/perl5/Dpkg/IPC.pm 
> > line 308.
> > dpkg-source: error: unable to execute tar --no-same-owner 
> > --no-same-permissions --anchored --no-wildcards --exclude 
> > land_sea_mask/r160_xx_19790930 ... --exclude 
> > bufrtables/C0000000000149010001.TXT -xf - gave error exit status 7
> > FAILED [dpkg-source died]
> > 
> > The full command line it tries to run here is over 327,000 bytes long,
> > so I can see how some kernels could reasonably reject it.  If
> > dpkg-source truly needs to pass an explicit list, I would suggest
> > using tar's --exclude-from=... option.  Otherwise, I believe it would
> > suffice to use --skip-old-files, or, if you want to treat overlaps as
> > errors, --keep-old-files (-k).
> > 
> > Could you please take a look?
> 
> Yes, I did, and I think it might actually be enough to stop adding all
> those --exclude for pre-existing symlinks, as tar should replace them
> with actual directories (at least according to tar docs, and for a
> very long time), but I've not yet tested if that really holds true.
> 
> Otherwise I think only --exclude-from= would be an appropriate
> replacement, although it would require a temp file.

I've just checked this now, and tar behaves properly, so I've removed
that code, and this should stop being an issue with dpkg 1.18.2.

Thanks,
Guillem


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to