tags 777819 + patch thanks Hi there. I’ve made a partial fix for building clementine under GCC5. The patch is attached and it’s a simple rearrangement of operands to prevent an error/bug due to operator precedence. The fix has already made it into the master branch of upstream.
This doesn’t completely fix the FTBFS though. I had to rebuild libprotobuf using GCC5 to allow linking using the new C++ ABI but that should fix itself over time. The latest problem is a link problem against TagLib::String::String. Linking CXX executable ../../clementine-tagreader cd /root/clementine-1.2.3+dfsg/obj-x86_64-linux-gnu/ext/clementine-tagreader && /usr/bin/cmake -E cmake_link_script CMakeFiles/clementine-tagreader.dir/link.txt --verbose=1 /usr/bin/c++ -DQT_NO_DEBUG_OUTPUT -DQT_NO_WARNING_OUTPUT --std=c++0x -U__STRICT_ANSI__ -Wl,-z,relro CMakeFiles/clementine-tagreader.dir/main.cpp.o CMakeFiles/clementine-tagreader.dir/tagreaderworker.cpp.o CMakeFiles/clementine-tagreader.dir/qrc_data.cxx.o -o ../../clementine-tagreader -rdynamic -ltag -lQtCore -lQtNetwork ../libclementine-common/liblibclementine-common.a ../libclementine-tagreader/liblibclementine-tagreader.a ../libclementine-common/liblibclementine-common.a -lprotobuf -ltag -lpthread ../libclementine-tagreader/liblibclementine-tagreader.a(tagreader.cpp.o): In function `TagReader::SaveFile(QString const&, pb::tagreader::SongMetadata const&) const': tagreader.cpp:(.text+0x62e0): undefined reference to `TagLib::String::String(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, TagLib::String::Type)' tagreader.cpp:(.text+0x63c6): undefined reference to `TagLib::String::String(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, TagLib::String::Type)' tagreader.cpp:(.text+0x64ac): undefined reference to `TagLib::String::String(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, TagLib::String::Type)' collect2: error: ld returned 1 exit status ext/clementine-tagreader/CMakeFiles/clementine-tagreader.dir/build.make:151: recipe for target 'clementine-tagreader' failed make[4]: *** [clementine-tagreader] Error 1 make[4]: Leaving directory '/root/clementine-1.2.3+dfsg/obj-x86_64-linux-gnu' CMakeFiles/Makefile2:1559: recipe for target 'ext/clementine-tagreader/CMakeFiles/clementine-tagreader.dir/all' failed make[3]: *** [ext/clementine-tagreader/CMakeFiles/clementine-tagreader.dir/all] Error 2 make[3]: Leaving directory '/root/clementine-1.2.3+dfsg/obj-x86_64-linux-gnu' Makefile:119: recipe for target 'all' failed make[2]: *** [all] Error 2 make[2]: Leaving directory '/root/clementine-1.2.3+dfsg/obj-x86_64-linux-gnu' dh_auto_build: make -j1 returned exit code 2 debian/rules:23: recipe for target 'override_dh_auto_build' failed make[1]: *** [override_dh_auto_build] Error 2 make[1]: Leaving directory '/root/clementine-1.2.3+dfsg' debian/rules:8: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 debuild: fatal error at line 1382: dpkg-buildpackage -rfakeroot -D -us -uc failed This doesn’t look like an ABI problem and I don’t have a fix yet, but thought I would post my work so far. Regards, Tim.
777819-fix-gcc5-ftbfs.patch
Description: Binary data
smime.p7s
Description: S/MIME cryptographic signature
