Package: trigger-rally-data
Version: 0.6.1-1
Severity: wishlist
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: umask
Control: fixed -1 0.6.1-0.1


Hi!

While working on the “reproducible builds” effort [1], we have noticed
that foo could not be built reproducibly.


In [2] you rewrote the d/rules file adding an override to dh_fixperms, that
previusly was executed. That way building with a different umask leads to
different perms [3]

Attached there is a (untested, sorry) patch to fix this.
Might look weird to see dh_fixperms after the custom bits, but befor the
refactor it was that way. So i also suggest checking whether that lines are
actually needeed.



 [1]: https://wiki.debian.org/ReproducibleBuilds
 [2]: 
https://anonscm.debian.org/cgit/pkg-games/trigger-rally-data.git/commit/?id=53d8b724714d7eab3715c7df074d580b0da850d4
 [3]: 
https://reproducible.debian.net/rb-pkg/unstable/amd64/trigger-rally-data.html
      (will vanish once fixed)



-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64, armel, armhf

Kernel: Linux 4.0.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540         .''`.
more about me:  http://mapreri.org                                 : :'  :
Launchpad user: https://launchpad.net/~mapreri                     `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia     `-
From 5442a4a4b3925c4c50b862aaac00e2eeb9b00d19 Mon Sep 17 00:00:00 2001
From: Mattia Rizzolo <mat...@mapreri.org>
Date: Fri, 19 Jun 2015 16:51:12 +0000
Subject: [PATCH] debian/rules: add a call to dh_fixperms inside the override,
 to allow reproducible builds

---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index a64c50d..4d4fd82 100755
--- a/debian/rules
+++ b/debian/rules
@@ -17,3 +17,4 @@ override_dh_fixperms:
 	cd debian/$(PACKAGE)/$(DATADIR) && find . -name '*.level' | xargs chmod ugo-x
 	cd debian/$(PACKAGE)/$(DATADIR) && find . -name '*.png' | xargs chmod ugo-x
 	cd debian/$(PACKAGE)/$(DATADIR) && find . -name '*.jpg' | xargs chmod ugo-x
+	dh_fixperms
-- 
2.1.4

Attachment: signature.asc
Description: Digital signature

Reply via email to