Hi everyone, I'm looking at Brandon's package for kafka, and here are some comments:
* did you sent an email to debian-mentors asking for comments? it's usually a good way to get exposure of a package and receive feedbacks about it * there is already a packaging effort from wikimedia at https://git.wikimedia.org/summary/operations%2fdebs%2fkafka.git/HEAD - did you look at it (eventually contacting them to have the packages in debian)? * you mention gradle in Debian is broken: have you investigated what needs to be done to fix it? * debian/changelog - it still contains 'UNRELEASED', that should be 'unstable' instead * debian/control - consider adding a Vcs-Browser field in source stanza - short description should start with a lowercase letter * debian/kafka.links - is empty and could be removed * debian/kafka.lintian-overrides - I think there is still a lot of "heat" around it and I would strongly advice to provide an init script * debian/kafka.postinst - you do some operations in 'configure' but it seems you dont undo them when removing/purging the package, which should happen instead * debian/rules - consider using the more compact: --with A,B instead of --with A --with B - it looks really suspicious the usage of HOME: have you tried to build your package in a clean chroot? - override_dh_systemd_start: true is, to say the least, unexpected, what it is for? * debian/watch - please provide it the package fails to build from source (FTBFS as you might find usually written) in pbuilder exactly when using HOME: dh_auto_clean GRADLE_USER_HOME=/tmp/buildd/.gradle ./gradlew clean Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain debian/rules:15: recipe for target 'override_dh_auto_clean' failed make[1]: *** [override_dh_auto_clean] Error 1 Please address these problems, and please ask all the questions you need! Cheers, -- Sandro Tosi (aka morph, morpheus, matrixhasu) My website: http://matrixhasu.altervista.org/ Me at Debian: http://wiki.debian.org/SandroTosi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
