On Fri, 29 May 2015 22:59:45 +0000 (UTC) Sergio benjamim Rocha filho <sergio_...@yahoo.com.br> wrote: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "vbam"
Hi,
I've had a look at this (because I'm interested), however I'm not a DD
so I can't actually sponsor the package for you.
Some of this stuff may be a bit picky... You can ask me if you have any
questions or if you disagree with something :)
general
* Have you considered maintaining the package as part of the
Debian Games team?
* Have you contacted Etienne Millon <>?
He may be interested in this (as the maintainer of the vba
package).
d/control:
* Why are there 2 GUI frontends to this package? Is there any
advantage of one over the other? Which one is the best / one
which you would recommend?
* The Vcs-Svn and Vcs-Browser fields in d/control are usually
used for packaging repositories (which contain a debian/
directory), not links to the upstream repositories.
* You can drop the version on cmake, squeeze already has 2.8.2.
* vba-common should be Architecture: all.
* You probably want a versioned dependency from vbam-gtk and vbam
-wx to vbam-common.
* nasm doesn't seem to be used in the build so you can drop it.
* The version of vba in the archive has a dependency from vba-gtk
to vba. Does this package need that?
* The trademark disclaimer probably doesn't need to be in the
description, but you can put it in d/copyright if you want (I
don't know how necessary it is).
d/changelog:
* Please squash all the changelog entries. You should generally
use one entry per version actually uploaded to Debian.
d/copyright:
* Need copyright information for files in CMakeScripts/ and data/
* The files licensed under GPL-2 only are problematic since there
is some GPL-3 files here as well. The files must be replaced or
re-licensed with permission of the author(s). If they aren't
used, then copyright file should say that.
d/patches/gtk.patch:
* Is this necessary? Can't you just use -DENABLE_GTK=ON?
d/rules:
* What are the commented lines (starting DEB_BUILD_ARCH_CPU) in
d/rules for? Remove them if they're now obsolete.
* Remove the stuff about CMAKE_VERBOSE_MAKEFILE, dh always
enables that flag anyway.
* CMAKE_INSTALL_PREFIX=/usr is also added by dh so you can remove
that as well.
build
* Please fix the 'dpkg-shlibdeps: warning: package could avoid a
useless dependency' warnings by using --as-needed or preventing
the libraries being linked.
* Try 'export DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed'
lintian (fix all of these)
W: vbam source: dep5-copyright-license-name-not-unique (paragraph at line 124)
W: vbam source: dep5-copyright-license-name-not-unique (paragraph at line 138)
W: vbam source: dep5-copyright-license-name-not-unique (paragraph at line 243)
W: vbam source: missing-license-paragraph-in-dep5-copyright gpl-2+ (paragraph
at line 169)
W: vbam source: missing-license-paragraph-in-dep5-copyright public-domain
(paragraph at line 36)
X: vbam-common: package-contains-no-arch-dependent-files
vbam-sdl segfault
I tried running a game with vbam in the vbam-sdl package. When closing
the program it segfaulted. This was the stacktrace. As you can see,
fclose was called with a NULL pointer.
#0 _IO_new_fclose (fp=0x0) at iofclose.c:54
#1 0x0000000000438cbe in SaveConfigFile () at
/tmp/vbam/vbam-1.8.0.1498/src/common/ConfigManager.cpp:783
#2 0x000000000042fc6a in main (argc=2, argv=0x7fffffffe198) at
/tmp/vbam/vbam-1.8.0.1498/src/sdl/SDL.cpp:1853
Tail of strace:
stat("/home/james/.vbam", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
getcwd("/tmp/vbam", 2048) = 10
stat("vbam.ini", 0x7ffd9bcb3ae0) = -1 ENOENT (No such file or directory)
stat("/home/james/.vbam/vbam.ini", 0x7ffd9bcb3ae0) = -1 ENOENT (No such file or
directory)
stat("/usr/share/vbam/vbam.ini", 0x7ffd9bcb3ae0) = -1 ENOENT (No such file or
directory)
stat("/etc/vbam.ini", 0x7ffd9bcb3ae0) = -1 ENOENT (No such file or directory)
getcwd("/tmp/vbam", 2048) = 10
stat("vbam.cfg", 0x7ffd9bcb3ae0) = -1 ENOENT (No such file or directory)
stat("/home/james/.vbam/vbam.cfg", 0x7ffd9bcb3ae0) = -1 ENOENT (No such file or
directory)
stat("/usr/share/vbam/vbam.cfg", 0x7ffd9bcb3ae0) = -1 ENOENT (No such file or
directory)
stat("/etc/vbam.cfg", {st_mode=S_IFREG|0644, st_size=5821, ...}) = 0
open("/etc/vbam.cfg", O_WRONLY|O_CREAT|O_TRUNC, 0666) = -1 EACCES (Permission
denied)
--- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0} ---
+++ killed by SIGSEGV (core dumped) +++
Segmentation fault
cppcheck output (possible coding mistakes):
$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open
any of the paths given.'
[src/common/ConfigManager.cpp:683]: (error) Pointer to local array variable
returned.
[src/common/Patch.cpp:173]: (error) Common realloc mistake: 'rom' nulled but
not freed upon failure
[src/filters/2xSaI.cpp:1271]: (error) Uninitialized variable: product1
[src/gb/gbCheats.cpp:173]: (error) Resource leak: f
[src/gba/GBA-thumb.cpp:1052]: (error) Uninitialized variable: value
[src/gba/GBA-thumb.cpp:1054]: (error) Uninitialized variable: value
[src/gba/GBA-thumb.cpp:1056]: (error) Uninitialized variable: value
[src/gba/GBA-thumb.cpp:165]: (error) Invalid number of character (() when these
macros are defined: '__GNUC__;__POWERPC__'.
[src/gba/GBALink.cpp:907]: (error) Uninitialized variable: numbytes
[src/sdl/debugger-expr.y:162]: (error) Resource leak: f
[src/gba/elf.cpp:1119]: (error) Common realloc mistake: 'elfFdes' nulled but
not freed upon failure
[src/gba/elf.cpp:2555]: (error) Common realloc mistake: 'ranges' nulled but not
freed upon failure
[src/gba/ereader.cpp:298]: (error) Resource leak: f
[src/gba/remote.cpp:1164]: (error) Resource leak: tlb
[src/gba/remote.cpp:1346]: (error) Resource leak: toExec
[src/gba/remote.cpp:2103]: (error) Memory leak: command
[src/gtk/main.cpp:123]: (error) Possible null pointer dereference: poWindow
[src/libretro/UtilRetro.cpp:145]: (error) Resource leak: fp
[src/sdl/SDL.cpp:659]: (error) Common realloc mistake: 'stateNameDest' nulled
but not freed upon failure
[src/sdl/SDL.cpp:662]: (error) Common realloc mistake: 'stateNameBack' nulled
but not freed upon failure
[src/sdl/SDL.cpp:1474]: (error) fprintf format string requires 1 parameter but
only 0 are given.
[src/win32/OpenGL.cpp:102]: (error) Memory leak: buf
[src/wx/sys.cpp:1033]: (error) Common realloc mistake: 'accum_prdata' nulled
but not freed upon failure
[src/wx/viewers.cpp:411]: (error) Array 'bit[16]' accessed at index 9998, which
is out of bounds.
[src/wx/viewers.cpp:431]: (error) Array 'bit[16]' accessed at index 9998, which
is out of bounds.
[src/wx/viewers.cpp:449]: (error) Array 'bit[16]' accessed at index 9998, which
is out of bounds.
[src/wx/viewers.cpp:477]: (error) Array 'bit[16]' accessed at index 9998, which
is out of bounds.
[src/wx/viewers.cpp:412]: (error) Array 'bitlab[16]' accessed at index 9998,
which is out of bounds.
[src/wx/wxvbam.cpp:679]: (error) Array 'recent_accel[10]' accessed at index 10,
which is out of bounds.
isutf8 output (checks for files with invalid utf-8):
./doc/ReadMe.MFC.txt: line 74, char 1, byte offset 6: invalid UTF-8 code
./src/wx/wxvbam.rc: line 32, char 1, byte offset 48: invalid UTF-8 code
./src/filters/xBRZ/xbrz.cpp: line 449, char 1, byte offset 116: invalid UTF-8
code
./src/win32/VBA.rc: line 181, char 1, byte offset 32: invalid UTF-8 code
Thanks,
James
signature.asc
Description: This is a digitally signed message part
