On Tue, May 12, 2015 at 05:57:55PM +0200, Kay Sievers wrote: > On Tue, May 12, 2015 at 2:01 PM, Julian Andres Klode <j...@debian.org> wrote: > > Control: forwarded -1 k...@vrfy.org > > > > (Adding Kay Sievers & Harald Hoyer from upstream) > > > > On Mon, Aug 25, 2014 at 09:10:48PM +0200, Michael Tautschnig wrote: > >> Package: gummiboot > >> Version: 45-2 > >> Usertags: goto-cc > >> Severity: wishlist > >> Tags: upstream > >> > >> While trying to build gummiboot using our research compiler infrastructure > >> the > >> build stumbled upon the following declaration in src/efi/console.c (from > >> line 29 > >> onwards): > >> > >> typedef EFI_STATUS (EFIAPI *EFI_INPUT_RESET_EX)( > >> struct _EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This; > >> BOOLEAN ExtendedVerification; > >> ); > >> > >> While even gcc -Wall -pedantic will emit warnings, clang entirely rejects > >> this. > >> To address this, the semicolons after the function parameters should be > >> replaced > >> by commas, and the last one should be omitted, like this: > >> > >> typedef EFI_STATUS (EFIAPI *EFI_INPUT_RESET_EX)( > >> struct _EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, > >> BOOLEAN ExtendedVerification > >> ); > >> > >> The same problem appears multiple times in that file. > >> > >> I'm not sure about the rationale for the chosen syntax and surely this is > >> an > >> upstream problem, but I couldn't figure out what their bugtracker was. > > > > I'm not sure either, I added the upstream authors to the list > > of recipients. > > Just a bug. Surprised that gcc even accepts that. Send a patch if you > like it in the gummiboot repo, I'll fix the version in the systemd > repo.
I'll just keep the bug open then, it will be closed when gummiboot is removed from unstable (after we have systemd-boot). -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. Be friendly, do not top-post, and follow RFC 1855 "Netiquette". - If you don't I might ignore you. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
