On Sat, 23 May 2015, Niels Möller wrote: [...] > > $ cat debian/patches/multiarch.patch > > --- a/aclocal.m4 > > +++ b/aclocal.m4 > > @@ -857,7 +857,7 @@ > > fi # shortcircut to system "stdint.h" > > # ------------------ PREPARE VARIABLES ------------------------------ > > if test "$GCC" = "yes" ; then > > -ac_cv_stdint_message="using gnu compiler "`$CC --version | head -1` > > +ac_cv_stdint_message="using gnu compiler $CC" > > else > > ac_cv_stdint_message="using $CC" > > fi > > If we go this path, maybe just drop the conditional and unconditionally > print "using $CC"?
Sure that would work too. It's mostly a matter of how minimal you want the patch to be compared to autoconf's code. > I'm not sure about the reason for displaying the version, but I guess > some older gcc versions did stdint and/or inttypes.h differently. I looked at the Git history of that file but all I found for this line was a big import dating back to 2007-02-14 creating that file among others. So nothing that explains the rational behind putting compiler information inside a C comment. > If you have the time, it would be helpful to look at the latest version > of AX_CREATE_STDINT_H (from autoconf archive) and see if it does > anything differently. I guess it would be this page: http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_create_stdint_h.m4 pointed to by https://www.gnu.org/software/autoconf-archive/ax_create_stdint_h.html So it still puts the gcc version in the comment. [...] > > For GMP_NUMB_BITS here are some thoughts: > > You must understand that nettle defines GMP_NUMB_BITS only if configured > with --enable-mini-gmp. This configuration is not intended to be > compatible with anything else, and should never be installed on a normal > debian system. I see. So given that the part inside the #if is irrelevant to Debian I think the simplest solution would be for the Debian package to apply a patch that makes it harmless. I'm torn between removing all five lines, and a more minimalistic one that replaces @GMP_NUMB_BITS@ with either '0' or 'mini-gmp is not supported' so the user gets a meaningful error if he tries to define NETTLE_USE_MINI_GMP anyway. -- Francois Gouget <fgou...@free.fr> http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.
