Hej
Thanks for this. Corrected and uploaded.
// Ola
On Mon, May 4, 2015 at 12:19 AM, Mats Erik Andersson <
mats.anders...@gisladisker.se> wrote:
> Package: debarchiver
> Version: 0.10.4
> Severity: important
>
> Hello there,
>
> ever since version 0.6.3 was released, in 2006, the code
> for checking duplicate upstream version has been defective.
> The variable '$upstream_version' is populated with the
> upstream version string of the original archive, but the
> variable '$upver' is late queried for its content, which
> is invariably empty! In practice this means that debarchiver
> is more inclined to refuse the removal of the incoming archive,
> than to carelessly remove it.
>
> This coding error would have been elementary, should the
> software have been written with strictures turned on.
>
> Best regards,
> Mats Erik Andersson
>
>
> Index: src/debarchiver.pl
> ===================================================================
> --- src/debarchiver.pl (revision 1)
> +++ src/debarchiver.pl (arbetskopia)
> @@ -2167,7 +2167,7 @@
> # only do checks of processing source tarballs
> if ($file =~ m/.tar.gz$/) {
> my @upstream_version = split(/-/, $ver);
> - $upstream_version = $upstream_version[0];
> + my $upver = $upstream_version[0];
>
> # get list of remaining *.changes files of this package
> upstream
> # version
> Index: patches/multiple_packages_one_orig_v2.diff
> ===================================================================
> --- patches/multiple_packages_one_orig_v2.diff (revision 1)
> +++ patches/multiple_packages_one_orig_v2.diff (arbetskopia)
> @@ -35,7 +35,7 @@
> + # only do checks of processing source tarballs
> + if ($file =~ m/.tar.gz$/) {
> + my @upstream_version = split(/-/, $ver);
> -+ $upstream_version = $upstream_version[0];
> ++ my $upver = $upstream_version[0];
> +
> + # get list of remaining *.changes files of this package
> upstream
> + # version
>
--
--- Inguza Technology AB --- MSc in Information Technology ----
/ o...@inguza.com Annebergsslingan 37 \
| o...@debian.org 654 65 KARLSTAD |
| http://inguza.com/ Mobile: +46 (0)70-332 1551 |
\ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
---------------------------------------------------------------
