Hi!
On 05/14/2015 08:37 AM, Ondřej Surý wrote:
On Wed, May 13, 2015, at 23:39, Hans van Kranenburg wrote:
2. What is your opnion on the previous thoughts about *never* asking to
replace the bird.conf file? The current handling (also with ucf) shows
the same behaviour as the conffile way.
I prefer doing thing in standardized way, that's more predictable and
already in place. I can think of one problem that's already solved by
using ucf, but would have to be handled by the postinst scripts just top
of my head:
- one of the standardized ways how to disable some service in Debian is
to remove it's conffile, but simply checking whether conffile exists or
not in postinst script would simply re-add user removed conffile. To fix
that you would have to add additional login in postinst to check whether
we have this is a new install or whether we are upgrading the package.
My take on this is that it's better to use well tested tool.
Agreed.
That said - ucf has an option to always retain user configfile by
setting UCF_FORCE_CONFFOLD environment variable (I never used it
before), so that's something I am going to use.
Ah, awesome! I just tested the upgrade from 1.4.5-1 to 1.5.0-3, without
questions asked.
3. The package is currently broken. Simply installing the package
results in errors now, because "router id 2001:DB8::1;" is not valid
bird configuration. See attached output. Did you test the package before
uploading?
I did, but obviously I missed this.
I found one still remaining issue, in bird.postrm:
I think the "foo" needs to be "bird" in:
ucfr --purge foo /etc/bird/$conf
Currently removing with --purge shows:
# apt-get remove --purge bird
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be REMOVED:
bird*
0 upgraded, 0 newly installed, 1 to remove and 4 not upgraded.
After this operation, 1,327 kB disk space will be freed.
Do you want to continue? [Y/n]
(Reading database ... 50350 files and directories currently installed.)
Removing bird (1.5.0-3) ...
Purging configuration files for bird (1.5.0-3) ...
ucfr: Association belongs to bird, not foo
ucfr: Aborting
dpkg: error processing package bird (--purge):
subprocess installed post-removal script returned error exit status 5
Processing triggers for man-db (2.7.0.2-5) ...
Errors were encountered while processing:
bird
[master ee0a660] committing changes in /etc after apt run
8 files changed, 762 deletions(-)
delete mode 100644 bird/bird.conf
delete mode 100644 bird/bird6.conf
delete mode 100644 bird/envvars
delete mode 100755 init.d/bird
delete mode 100755 init.d/bird6
delete mode 100644 init/bird.conf
delete mode 100644 init/bird6.conf
E: Sub-process /usr/bin/dpkg returned an error code (1)
P.S. are you using git://anonscm.debian.org/users/ondrej/bird.git for
packaging? Could you push your changes?
Sure, pushed.
Thanks a lot!
--
Hans van Kranenburg - System / Network Engineer
T +31 (0)10 2760434 | hans.van.kranenb...@mendix.com | www.mendix.com
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
