Package: debarchiver
Version: 0.10.4
Severity: important

Hello there,

ever since version 0.6.3 was released, in 2006, the code
for checking duplicate upstream version has been defective.
The variable '$upstream_version' is populated with the
upstream version string of the original archive, but the
variable '$upver' is late queried for its content, which
is invariably empty! In practice this means that debarchiver
is more inclined to refuse the removal of the incoming archive,
than to carelessly remove it.

This coding error would have been elementary, should the
software have been written with strictures turned on.

Best regards,
  Mats Erik Andersson


Index: src/debarchiver.pl
===================================================================
--- src/debarchiver.pl  (revision 1)
+++ src/debarchiver.pl  (arbetskopia)
@@ -2167,7 +2167,7 @@
        # only do checks of processing source tarballs
         if ($file =~ m/.tar.gz$/) {
            my @upstream_version = split(/-/, $ver);
-           $upstream_version = $upstream_version[0];
+           my $upver = $upstream_version[0];
            
            # get list of remaining *.changes files of this package upstream 
            # version
Index: patches/multiple_packages_one_orig_v2.diff
===================================================================
--- patches/multiple_packages_one_orig_v2.diff  (revision 1)
+++ patches/multiple_packages_one_orig_v2.diff  (arbetskopia)
@@ -35,7 +35,7 @@
 +      # only do checks of processing source tarballs
 +      if ($file =~ m/.tar.gz$/) {
 +              my @upstream_version = split(/-/, $ver);
-+              $upstream_version = $upstream_version[0];
++              my $upver = $upstream_version[0];
 +                      
 +              # get list of remaining *.changes files of this package 
upstream 
 +              # version


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to