Package: gitpkg Version: 0.26 Severity: minor Tags: patch A trailing slash in the patch directory argument (-o) of git-debcherry silently breaks the patch series file, because the generation unconditionally appends a slash to the value, causing the sed command to fail and leaving absolute pathnames in the series.
Proposed patch attached. -- System Information: Debian Release: 8.0 APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages gitpkg depends on: ii dpkg-dev 1.17.25 ii git 1:2.1.4-2.1 gitpkg recommends no packages. Versions of packages gitpkg suggests: ii devscripts 2.15.3 -- no debconf information
>From 9de71baaaa37282a0fbae44a2582dfd4d1cc7e8d Mon Sep 17 00:00:00 2001 From: Niko Tyni <nt...@debian.org> Date: Sun, 3 May 2015 13:50:04 +0300 Subject: [PATCH] Strip trailing slash from patch directory A trailing slash in the patch directory argument would silently break the patch series file, because the generation unconditionally appends a slash to the value. --- git-debcherry | 1 + 1 file changed, 1 insertion(+) diff --git a/git-debcherry b/git-debcherry index 76032c7..4766600 100755 --- a/git-debcherry +++ b/git-debcherry @@ -122,6 +122,7 @@ while : ; do *) patch_dir=$(pwd)/$patch_dir esac + patch_dir=$(echo "$patch_dir" | sed 's,/$,,') shift; shift; ;; -- 2.1.4
