I put together a patch for memory leaks in xfce4-power-manager-1.4.1
based on a back-port of upstream fix
(https://github.com/xfce-mirror/xfce4-power-manager/commit/18ead01edbc013abf620e3a9ea31eabcad1ae267)
and additional memory leak found using valgrind.

Tested & appears that the plugin memory footprint is now stable.

-Phil Davidov
Index: xfce4-power-manager-1.4.1/common/xfpm-power-common.c
===================================================================
--- xfce4-power-manager-1.4.1.orig/common/xfpm-power-common.c
+++ xfce4-power-manager-1.4.1/common/xfpm-power-common.c
@@ -303,10 +303,12 @@ get_device_icon_name (UpClient *upower,
 	}
 	else
 	{
-	    icon_name = icon_prefix;
+        icon_name = g_strdup_printf ("%s", icon_prefix);
 	}
     }
 
+    g_free (icon_prefix);
+
     return icon_name;
 }
 
Index: xfce4-power-manager-1.4.1/panel-plugins/power-manager-plugin/power-manager-button.c
===================================================================
--- xfce4-power-manager-1.4.1.orig/panel-plugins/power-manager-plugin/power-manager-button.c
+++ xfce4-power-manager-1.4.1/panel-plugins/power-manager-plugin/power-manager-button.c
@@ -486,6 +486,7 @@ battery_device_remove_pix (BatteryDevice
             g_object_unref (battery_device->img);
             battery_device->img = NULL;
         }
+        g_object_unref (battery_device->pix);
         battery_device->pix = NULL;
     }
 }

Reply via email to