On 18.04.2015 at 15:37, Dirk Eddelbuettel wrote: > > On 18 April 2015 at 15:22, Johannes Ranke wrote: > | Am Samstag, 18. April 2015, 06:27:03 schrieb Dirk Eddelbuettel: > | > On 18 April 2015 at 11:15, Philip Rinn wrote: > | > | Hi, > | > | > | > | I think this patch is more what I wanted. > | > | It now sets the build-timestamp to the time of the last changelog entry > if > | > | the maintainer does not set builttimeStamp explicitly. > | > | With this change almost all GNU R packages in Debian would automatically > | > | build reproducible. > | > > | > And I presume that is what we want? I never heard from the > reproducibility > | > group after I made the two patches (cf old bug report) to R itself and > | > r-cran.mk.
Yes, I think so. I asked on the #debian-reproducible IRC channel yesterday and got a "looks good to me" back. This change would make at least 223 [1] GNU R packages build reproducible - that's about 5% of all FTBR packages. > | Without having further background information I would say that the build- > | timestamp should be either set to the build time (to carry correct > | information) or not at all (to have reproducible builds). > > Context: R _always_ puts one hin, hence the discussion in the earlier bug > report and my (long-accepted) upstream ptahc to be able to override. > > What Philip is suggesting here is to use the hook I provided with a suitable > value -- the timestamp from debian/changelog. I think I'll do that. Well, defaulting to builttimeStamp = " " would work too, but for me it looks better to have the "timestamp when the package was modified" there. > Dirk, at a workshop > > | Johannes > | > | > Too bad you sent me this today. I just made four uploads of R in the last > | > few days leading up to R 3.2.0. Yes, I saw that, but I didn't had time earlier this week. Having that set with the start of the new release cycle would have been nice but it's not mandatory I think. Philip > | > > | > Dirk > | > > | > | Best, > | > | Philip > | > | > | > | x[DELETED ATTACHMENT usable_builttimeStamp2.patch, text/x-patch] > | > | x[DELETED ATTACHMENT signature.asc, application/pgp-signature] > [1] https://reproducible.debian.net/issues/unstable/timestamps_in_description_files_generated_by_r-base-dev_issue.html
signature.asc
Description: OpenPGP digital signature
