Hello Cameron, first thanks for your review and your upstart file.
Am Dienstag, den 07.04.2015, 08:41 -0700 schrieb Cameron Norman: > On Mon, Apr 6, 2015 at 10:24 PM, Jörg Frings-Fürst > <deb...@jff-webhosting.net> wrote: > > Hello, > > > > I have refresh the package bitz-server[1]. > > > > Please can someone review it? > > I am not a DD, but I will try to do my best to review this. > > It includes a library in its sources, > https://github.com/uditha-atukorala/socket-library > > This library also creates a strange "unknown" author in the > debian/copyright file. > > I am not sure if either of those are acceptable, however I am sure the > first one is at least discouraged (in favor of packaging the library > separately and listing it in the build depends). The "unknown" author is the first one from the source files. And I think that the this line must include into d/copyright. > > Also, I have attached an Upstart job for you to include if you would > like. Just place it at the path debian/bitz-server.upstart and it will > be automatically shipped with the package. It is not necessary to > include this to get bitz-server packaged, it is just something extra. > I have add your file and set the copyright to you[1]. Many thanks. > Good luck, > -- > Cameron Norman CU Jörg [1] http://mentors.debian.net/debian/pool/main/b/bitz-server/bitz-server_0.1.6-1.dsc -- New: GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB 30EE 09F8 9F3C 8CA1 D25D GPG key (long) : 09F89F3C8CA1D25D GPG Key : 8CA1D25D CAcert Key S/N : 0E:D4:56 Old pgp Key: BE581B6E (revoked since 2014-12-31). Jörg Frings-Fürst D-54526 Niederkail Threema: SYR8SJXB IRC: j_...@freenode.net j_...@oftc.net My wish list: - Please send me a picture from the nature at your home.
signature.asc
Description: This is a digitally signed message part
