Control: tags -1 + patch

On Wed, 11 Mar 2015 12:02:19 +0100 Jakub Wilk <jw...@debian.org> wrote:
> Package: udev
> Version: 215-12
> Usertags: serious
> 
> After I upgraded kmod to 20-1, the udev init script fails to create some 
> static nodes:
> | unparseable line (c! /dev/cpu/microcode 0600 - - - 10:184)
> | unparseable line (c! /dev/autofs 0600 - - - 10:235)
> | unparseable line (c! /dev/btrfs-control 0600 - - - 10:234)
> | unparseable line (c! /dev/net/tun 0600 - - - 10:200)
> | unparseable line (c! /dev/ppp 0600 - - - 108:0)
> | unparseable line (c! /dev/uinput 0600 - - - 10:223)
> | unparseable line (c! /dev/snd/seq 0600 - - - 116:1)
> 
> Apparently that's due to this change in kmod:
> | - static-nodes: when writing in tmpfiles format, indicate that
> |   creation of static nodes should only happen at boot. This is used and
> |   required by systemd-217+.

This needs two fixes, for the systemd, we need this patch from upstream [1]:

--- a/units/systemd-tmpfiles-setup-dev.service.in
+++ b/units/systemd-tmpfiles-setup-dev.service.in
@@ -17,4 +17,4 @@ ConditionCapability=CAP_SYS_MODULE
[Service]
Type=oneshot
RemainAfterExit=yes
-ExecStart=@rootbindir@/systemd-tmpfiles --prefix=/dev --create
+ExecStart=@rootbindir@/systemd-tmpfiles --prefix=/dev --create --boot


For sysvinit, the udev init script, I propose the following change
(acked by Marco):

diff --git a/debian/udev.init b/debian/udev.init
index fd75031..d144d08 100644
--- a/debian/udev.init
+++ b/debian/udev.init
@@ -95,8 +95,8 @@ make_static_nodes() {
   while read type name mode uid gid age arg; do
     [ -e $name ] && continue
     case "$type" in
-      c|b) mknod -m $mode $name $type $(echo $arg | sed 's/:/ /') ;;
-      d) mkdir $name ;;
+      c|b|c!|b!) mknod -m $mode $name $type $(echo $arg | sed 's/:/ /') ;;
+      d|d!) mkdir $name ;;
       *) echo "unparseable line ($type $name $mode $uid $gid $age
$arg)" >&2 ;;
     esac


We do not differentiate between early boot in the sysv init script and
simply map it to the existing rules. The reason is, that we do not
support starting the init script in multi-user mode anyway.

We also decided, to apply these two patches to jessie, instead of
reverting the changes in kmod. This will make the jessie → stretch
upgrade simpler by avoiding Breaks during the upgrade, so it can be
considered future-proofing.


Michael


[1]
http://cgit.freedesktop.org/systemd/systemd/commit/?id=8c94052ee543c3598a3c7b0c46688150aa2c6168


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to