Package: rsnapshot
Followup-For: Bug #743310

Hi,

I'm affected by this bug as well.

The following commit fixes the problem for me:

https://github.com/intosi/rsnapshot/commit/f0b3b27d174257bf2a8ad29b8c36499bb7b2fb79
https://github.com/intosi/rsnapshot/commit/f0b3b27d174257bf2a8ad29b8c36499bb7b2fb79.patch

It is referenced in PR#15 in the "new" upstream repo but not merged yet.
https://github.com/rsnapshot/rsnapshot/pull/15

Patch is attached.

Bernhard
>From f0b3b27d174257bf2a8ad29b8c36499bb7b2fb79 Mon Sep 17 00:00:00 2001
From: Edwin Mons <g...@home.mons.net>
Date: Wed, 18 Sep 2013 22:39:11 +0200
Subject: [PATCH] Fix --rsh commandline option

The --rsh=... argument to rsync was erroneously quoted when added to the
@rsync_long_args_stack with options set.

Test-Information:

Unit tests pass.
Tested and verified on Debian 7.0
---
 rsnapshot-program.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rsnapshot-program.pl b/rsnapshot-program.pl
index 85972fd..5a20d0b 100755
--- a/rsnapshot-program.pl
+++ b/rsnapshot-program.pl
@@ -3412,7 +3412,7 @@ sub rsync_backup_point {
 		
 		# if we have any args for SSH, add them
 		if ( defined($ssh_args) ) {
-			push( @rsync_long_args_stack, "--rsh=\"$config_vars{'cmd_ssh'} $ssh_args\"" );
+			push( @rsync_long_args_stack, "--rsh=$config_vars{'cmd_ssh'} $ssh_args" );
 			
 		# no arguments is the default
 		} else {

Reply via email to