On 03/18/2015 09:09 PM, Adam D. Barratt wrote: > Well, not really. A debdiff from which you'd filtered the patch was > attached, as was the patch. I'm not convinced that actually provided any > benefit over simply providing the unfiltered debdiff.
I personally always have trouble reading nested diffs ('+-' vs '-+',
anybody?). So this was intended to be helpful. Apologies, if it's not.
Granted, an entire file added is not quite as hard to read (i.e. no '-+'
possible).
> ++ write_allowed_paths.push_back("/tmp/*.xml");
>
> Is that really intended? (Both the hardcoding of /tmp/ rather than using
> something respecting TMPDIR and being allowed to write any ".xml"
> there.)
It certainly matches Nasal/IOrules in flightgear-data, so it seems well
intended, yes. And as advertized, it's clearly more restrictive than it
used to be.
According to the comment in that same file, only $FG_HOME and $FG_ROOT
are known variables to be replaced, there. Adding $TMPDIR might be a
bigger effort, but I'm not quite sure what Nasal scripts need to write
temporary XML files.
Rebecca, care to comment?
Regards
Markus Wanner
signature.asc
Description: OpenPGP digital signature
