Hello Gianfranco! Thank you for your work on the s3cmd package. I'm not able to sponsor your package at this time, but I've done a review for you to help fix up a couple of nitpicks while you wait.
The most concerning issue to me is the change in d/copyright from GPL-2 to GPL-2+ for the files under debian/. Matching them to upstream is best practice, to be sure, but to do so needs the permission of the authors of all the files underneath there - especially, it looks like, Mikhail Gusarov. It's not clear to me whether Matt Domsch's permission might also be needed; it certainly couldn't hurt, though. The man page has a couple of errors as well - groff is picking up some text and trying to apply it as a macro. There are also unescaped "-"'s that need to be escaped so they are not mistaken as hyphens instead of minuses. There's also a spelling error in the man file. All of these are upstream problems - probably with the tool they are using to create the manpage itself - but should be fixed if possible. Other than that, the remaining tweaks are minor. You should install the upstream changelog since it's provided. Upstream does provide GPG signatures of the downloads, so you should verify them if possible - the uscan(1) manpage has details about how to do so. That will require changing the watch file from github to sourceforge. Thanks again for your work on s3cmd, and on Debian! If you have questions, please reach out to me. Sincerely, -- Harlan Lieberman-Berg ~hlieberman -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
