On 03/12/2015 05:03 AM, Paul Wise wrote: > On Thu, 2015-03-12 at 00:30 +0100, Peter Spiess-Knafl wrote: > > > If you look at the upstream Makefile you will notice that you also > need to override dh_auto_build as the prefix is used in building > the script. >
Fixed. > > That is an incorrect place to build the manual page, you should > build everything in dh_auto_build. The manual page should be built > from the codespell script instead of the codespell.py script, that > will allow you to drop the sed commands you added also. > Fixed. Even though one sed command for deleting the "Usage: ..." string is still required. > Then dh_installman doesn't need to be overridden as you have a > configuration file for it already. Removed the override. > I would suggest not cloning things into /tmp, personally I use the > myrepos tool and I clone codespell into ~/dev/qa/codespell and then > I do my Debian packaging for codespell in > ~/dev/debian/qa/codespell. > myrepos is great tool. Thank you for mentioning it. > Ah, I see. dh_auto_test does not need to be overridden, `make > check` should be run by dh_auto_test by default. > Removed the override. >> It is not contained in the 1.7 release. I added a patch. > > Ok, thanks. The patches need more DEP-3 meta-data, at minimum, Bug > or Forwarded and Applied-Upstream. > > http://dep.debian.net/deps/dep3/ > Did not know about DEP3. I added more information to the patches. >> What tool is that? > > That is Config::Model's cme tool, as run by check-all-the-things, > links: > > https://lists.debian.org/debian-devel-announce/2015/03/msg00004.html > > https://anonscm.debian.org/cgit/collab-maint/check-all-the-things.git > https://packages.debian.org/sid/libconfig-model-dpkg-perl > https://packages.debian.org/sid/libconfig-model-perl > > Package maintainers should be subscribed to debian-devel-announce. > I am subscribed to debian-devel-announce. Started using check-all-the-things today. I will see what I can contribute to that tool. >> Contacted upstream. I will provide a pull-request on github: >> https://github.com/lucasdemarchi/codespell/issues/27#issuecomment-78270203 > >> > One other thing you could ask upstream about is providing a clean > target in the Makefile so that debian/clean can be > removed/reduced. > Already filed a PR: https://github.com/lucasdemarchi/codespell/pull/28 I again uploaded a new version to mentors. Thanks again. Greetings Peter -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
