severity 779797 serious thanks Le mercredi 04 mars 2015 à 21:55 +0100, intrig...@debian.org a écrit : > Package: gdisk > Version: 0.8.10-1 > Severity: important > X-Debbugs-Cc: u...@451f.org > > Hi,
Hi, > > tl;dr: > > * In Wheezy, gdisk correctly returns exit code 0 upon success. > > * In Jessie, gdisk mistakenly returns exit code 1 after various > successful operations. This breaks any tool that uses gdisk for > such operations... and bothers checking its exit code. No idea if > the reverse-dependencies in Debian are affected, but it does break > Tails Installer (not in Debian yet, will be uploaded by the end of > August) on Jessie. > > * This regression has been identified upstream in March, 2014. > It was fixed in upstream Git back then. It's the HEAD of their > master branch, and no release was put out since. > > The attached patchset imports the fix from upstream (not the entire > commit, that sadly is non-atomic and contains unrelated changes -- > just the relevant changes), and updates d/changelog accordingly. > I've generated with git format-patch from the Vcs-Git. I've also patched gdisk_test.sh to test return code of partition table creation, like you've made in your test. > > The attached reproducer script allows anyone to confirm the summary > I made above. The results I see on Wheezy, Jessie, and Jessie + the > upstream fix follow. > > With my Tails hat, I'd love to see this bug fixed in Jessie (otherwise > we'll have to ship a modified gdisk in Tails). > > With my Debian hat, I'm unsure. On the one hand, arguably it's not RC, > and if nobody reported this bug at this stage of the release cycle, > then it's probably big deal to release with it, and not worth taking > the risk to modify the package. On the other hand that's a nasty > regression, and we don't know how many home-made scripts running under > `set -e' will be broken once their authors upgrade their systems > to Jessie. > > Guillaume, what do you think? If you feel it's RC, please bump > severity. I can take care of NMU'ing and talking to the release team > if it helps — just let me know. I've prepared a fixed version on mentors: http://mentors.debian.net/debian/pool/main/g/gdisk/gdisk_0.8.10-2.dsc It would be great if you can upload it to unstable and include it for Jessie (as i've bumped the severity to serious; i agree with you that without the upstream fix, it can break user scripts). -- Guillaume Delacour <g...@iroqwa.org>
signature.asc
Description: This is a digitally signed message part
