On 03/04/2015 11:47 PM, Sebastiaan Couwenberg wrote: > Thanks for the fixes. I've pushed some more changes for various things > I encountered.
Thanks for those. Using npm2deb for the first time made me miss some of my normal steps. > > Did you notice that the upstream build process requires itself? No - I did notice that the upstream build (and tests) did not work, but not that the "require" was the reason for it. I was looking to see if we could use tools/build.js to build the minified js instead of using uglify. After giving up, my thought was to work with upstream to fix it later - but I am happy to do that now instead. > The tools/build.js script also does some modifications to the source > when it generates the js/main/ code from the source. > > If installing the unmodified source is not sufficient, we may need to > find a different solution to replace build.js to bootstrap this package. I might raise an issue upstream and see what they say. It would be good to have the upstream build and tests working. > I haven't tested this yet. After the doing that, I suppose the final thing is to repack to remove the pre-built minified js. Cheers, Ross
signature.asc
Description: OpenPGP digital signature
