Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock

Hi,

we have a serious upgrade problem with the qtsmbstatus package from
wheezy. Even after the recently added Breaks in samba, the upgrade paths
are still failing (#779666): 

  Setting up samba (2:4.1.17+dfsg-1) ...
  Installing new version of config file /etc/init.d/samba ...
  Installing new version of config file /etc/logrotate.d/samba ...
  update-alternatives: warning: alternative /usr/bin/smbstatus.samba3 (part of 
link group smbstatus) doesn't exist; removing from list of alternatives
  update-alternatives: warning: /etc/alternatives/smbstatus is dangling; it 
will be updated with best choice
  insserv: Service samba has to be enabled to start service qtsmbstatusd
  insserv: exiting now!
  update-rc.d: error: insserv rejected the script header
  dpkg: error processing package samba (--configure):
   subprocess installed post-installation script returned error exit status 1

samba has changed what it's initscript provides, therefore
/etc/init.d/qtsmbstatusd needs to be upgraded as well - or at least
disabled, but this does not happen on removal, only on purge.

I have prepared a QA upload for sid that adds a preinst script to
temporarily deactivates the old incompatible initscript, that has fixed
the issue in my piuparts tests. The problem: this cannot be backported
to jessie since qtsmbstatus is not part of testing right now.

The easiest solution would be to allow qtsmbstatus back into jessie, a
proposed debdiff (relative to wheezy) is attached. Better solutions welcome.

I personally have *no* interest in qtsmbstatus beyond fixing upgrade
issues.

Please unblock package qtsmbstatus

unblock qtsmbstatus/2.2.1-4


Andreas
diff --git a/debian/changelog b/debian/changelog
index c10849b..7ce3807 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,25 @@
+qtsmbstatus (2.2.1-4) UNRELEASED; urgency=medium
+
+  * QA upload.
+  * qtsmbstatus-server.preinst: Deactivate our old init script that has
+    dependencies incompatible with the new samba package to allow
+    configuration of the new samba package before ourselves.  (Closes: #xxxxxx)
+  * Revert to debhelper compat level 7.
+
+ -- Andreas Beckmann <a...@debian.org>  Tue, 03 Mar 2015 19:24:25 +0100
+
+qtsmbstatus (2.2.1-3) unstable; urgency=medium
+
+  * QA upload.
+  * Switch qtsmbstatusd.init from 'Required-Start: samba' to 'Should-Start:
+    smbd samba-ad-dc' to restore installability with current samba packages.
+    No warranty that qtsmbstatusd is working properly!  (Closes: #722465)
+  * Update Vcs-* URLs.
+  * Switch to debhelper compat level 9.
+  * Switch to copyright-format 1.0.
+
+ -- Andreas Beckmann <a...@debian.org>  Sat, 10 Jan 2015 16:44:03 +0100
+
 qtsmbstatus (2.2.1-2) unstable; urgency=low
 
   * QA upload.
diff --git a/debian/control b/debian/control
index 6146ae4..d041b67 100644
--- a/debian/control
+++ b/debian/control
@@ -8,8 +8,8 @@ Build-Depends:
  libqt4-dev
 Standards-Version: 3.9.2
 Homepage: http://qtsmbstatus.free.fr/
-Vcs-Git: git://git.debian.org/collab-maint/qtsmbstatus.git
-Vcs-Browser: http://git.debian.org/?p=collab-maint/qtsmbstatus.git
+Vcs-Git: git://anonscm.debian.org/collab-maint/qtsmbstatus.git
+Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/qtsmbstatus.git
 
 Package: qtsmbstatus-language
 Architecture: all
diff --git a/debian/copyright b/debian/copyright
index d844b72..836fccd 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,30 +1,31 @@
-Format-Specification: http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=135
-Name: QtSmbstatus
-Maintainer: Daniel Rocher <daniel.roc...@adella.org>
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: QtSmbstatus
+Upstream-Contact: Daniel Rocher <daniel.roc...@adella.org>
 Source: http://qtsmbstatus.free.fr/index.php?page=downloads
 
+Files: *
 Copyright: 2004-2008, Daniel Rocher <daniel.roc...@adella.org>
 License: GPL-2+
 
-File: ./debian/*
+Files: debian/*
 Copyright:
- 2009-2010, Alessio Treglia <quadris...@ubuntu.com>
+ 2009-2011, Alessio Treglia <quadris...@ubuntu.com>
  2007, Daniel Rocher <daniel.roc...@adella.org>
 License: GPL-2+
 
 License: GPL-2+
- This program is free software; you can redistribute it and/or modify
+ This package is free software; you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation; either version 2 of the License, or
  (at your option) any later version.
  .
- This program is distributed in the hope that it will be useful,
+ This package is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.
  .
- You should have received a copy of the GNU General Public License along
- with this program; if not, write to the Free Software Foundation, Inc.,
- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-X-Comment: On Debian systems the full text of the GNU General Public
- License can be found in the `/usr/share/common-licenses/GPL-2' file.
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>
+ .
+ On Debian systems, the complete text of the GNU General
+ Public License version 2 can be found in "/usr/share/common-licenses/GPL-2".
diff --git a/debian/qtsmbstatus-server.preinst b/debian/qtsmbstatus-server.preinst
new file mode 100644
index 0000000..386f9c9
--- /dev/null
+++ b/debian/qtsmbstatus-server.preinst
@@ -0,0 +1,12 @@
+#!/bin/sh
+set -e
+
+#DEBHELPER#
+
+# Deactivate old init script that has dependencies incompatible with
+# new samba to allow configuration of the new samba package.
+if [ "$1" = "upgrade" ] || [ "$1" = "install" ]; then
+	if dpkg --compare-versions "$2" lt-nl "2.2.1-4~" ; then
+		update-rc.d -f qtsmbstatusd remove
+	fi
+fi
diff --git a/debian/qtsmbstatus-server.qtsmbstatusd.init b/debian/qtsmbstatus-server.qtsmbstatusd.init
index eff0e48..88bda46 100644
--- a/debian/qtsmbstatus-server.qtsmbstatusd.init
+++ b/debian/qtsmbstatus-server.qtsmbstatusd.init
@@ -5,8 +5,9 @@
 # For LSB
 ### BEGIN INIT INFO
 # Provides:          qtsmbstatusd
-# Required-Start:    $remote_fs $syslog samba
+# Required-Start:    $remote_fs $syslog
 # Required-Stop:     $remote_fs $syslog
+# Should-Start:      smbd samba-ad-dc
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: start qtsmbstatusd server at boot time

Reply via email to