Control: tags -1 patch On Fri, 12 Dec 2014 17:40:06 +0000 James Cowgill <james...@cowgill.org.uk> wrote: > Hi, > > libhdf4 FTBFS on mips64el because it chooses the size of hdf_pint_t > incorrectly. This results in a lot of warnings and causes this assertion > to fail near the end of the log:
So I had a look at fixing this and it seems that there was already another bug (#753493) on this issue and you tried to fix it in this commit: https://anonscm.debian.org/cgit/pkg-grass/hdf4.git/commit/?id=683f409c2e11b4cd3f20f62bc01ba02f839656bc Unfortunately, you changed the typedefs for ARM instead of MIPS so the bug wasn't fixed. Thankfully since int and long are the same on 32-bit ARM, it had no effect there and nothing broke. I've attached a patch to the hdfi.h patch which has the correct line numbers against 4.2.10-3. Thanks, James
--- a/debian/patches/hdfi.h 2014-10-21 14:20:19.000000000 +0100 +++ b/debian/patches/hdfi.h 2015-02-27 23:48:18.397275292 +0000 @@ -324,14 +324,14 @@ +typedef unsigned char uint8; +typedef short int int16; +typedef unsigned short int uint16; -+typedef long int int32; -+typedef unsigned long int uint32; ++typedef int int32; ++typedef unsigned int uint32; +typedef int intn; +typedef unsigned int uintn; +typedef float float32; +typedef double float64; +typedef long intf; /* size of INTEGERs in Fortran compiler */ -+typedef int hdf_pint_t; /* an integer the same size as a pointer */ ++typedef long hdf_pint_t; /* an integer the same size as a pointer */ +#define FNAME_POST_UNDERSCORE +#define _fcdtocp(desc) (desc) +
