Package: ucspi-tcp-ipv6
Version: 1:0.88-3
Severity: normal
Tags: ipv6

Dear Gerrit,

I have found a problem with ucspi-tcp-ipv6 package; namely that
tcprules dies when it encounters ipv6 address in rules file.
E.g. adding ipv6 address to /etc/tcp.smtp fails:

2 root@palladium ~ # qmailctl cdb
tcprules: fatal: unable to parse this line: 
2001:4898:e0:66:82fa:5bff:fe0f:c0c9:allow,WHITELISTED="yes"
Reloaded /etc/tcp.smtp.

I have discussed this issue with Felix von Leitner (the original
author of the ipv6 patch for ucspi-tcp) and he's under the impression
this is an issue related to this debian package.

Because his patch does add the support for ipv6 addresses in tcprules.
(works for him)

We compared the tcprules.c file and the one shipping with ucspi-tcp-ipv6
package seems to be unaffected by the changes providing the necessary
support. E.g. tcprules.c:126 reads:

colon = byte_chr(x,len,':');

which causes the input rule (current config file line) to be splitted
at first colon, using the left side as an address and right side as
instructions. Which fails to validate in the next step.

Felix's patch is different:

126     colon = 0;
127     for (;;) {
128       int tmp;
129       tmp = byte_chr(x + colon,len - colon,':');
130       colon += tmp;
131       if (colon == len) continue;
132       if (byte_equal(x+colon+1,4,"deny") || byte_equal(x+colon+1,5,"allow"))
break;
133       ++colon;
134     }

which causes the address/instructions splitting to work properly.

This leads me to believe there was some omission when fefe's patch
was included in the package.

Could you please revisit his ipv6 patch and possibly address this issue?

Cheers,

Michal

-- System Information:
Debian Release: 7.8
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages ucspi-tcp-ipv6 depends on:
ii  libc6  2.13-38+deb7u7

ucspi-tcp-ipv6 recommends no packages.

ucspi-tcp-ipv6 suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to