Looks like this patch is not applied yet. I can move value check to parse_options and send another version of patch. As for macros - yes, I already mentioned them in debian bug report thread. There are three of them (INTERVAL, RUN_INTERVAL, PROGRESS_CHARS) which are improperly (IMO) used instead of corresponding lowercase variables. I thought these changes should go to another patch.
On 02/17/2015 08:08 PM, Sebastian Andrzej Siewior wrote: > * Boris Egorov | 2014-11-27 16:20:34 [+0600]: > >> Program will crash if nr_runs is 0 due to dividing by it in >> print_results(). Let's exit early instead. >> >> Fixes: http://bugs.debian.org/716237 > > Has this been dealt with? I can't see this applied. I would prefer > doing the value check in parse_options() itself. And looking at it, it > seems that run_interval is interval ignored. Or is there macro magic > invovled? > >> Signed-off-by: Boris Egorov <ego...@linux.com> >> --- >> src/rt-migrate-test/rt-migrate-test.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/src/rt-migrate-test/rt-migrate-test.c >> b/src/rt-migrate-test/rt-migrate-test.c >> index e3c7a09..876a122 100644 >> --- a/src/rt-migrate-test/rt-migrate-test.c >> +++ b/src/rt-migrate-test/rt-migrate-test.c >> @@ -465,6 +465,11 @@ int main (int argc, char **argv) >> parse_options(argc, argv); >> + if (nr_runs <= 0) { >> + fprintf(stderr, "Warning, --loops argument is non-positive. >> Exiting.\n"); >> + exit(-1); >> + } >> + >> signal(SIGINT, stop_log); >> if (argc >= (optind + 1)) >> -- >> 2.1.3 > > Sebastian > -- Best regards, Boris Egorov -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
