On Wed Dec 14, 2005 at 06:36:21PM +0100, Ola Lundqvist wrote: > Hi > > On Tue, Dec 13, 2005 at 11:59:25PM -0500, The Anarcat wrote: > > Package: util-vserver > > Version: 0.30.209-1 > > Severity: normal > > Tags: patch > > > > Ok, bear with me here, i've spent the whole day tracking down problems > > in the package, and this is all i've figured. It is benign, really, but > > is clearly a bug. > > > > In /usr/lib/util-vserver/functions, you have a call to the "colorize" > > function. It doesn't respect the usage of the function: > > > > ## Usage: colorize <style> <command> > > > > You will see the behavior when trying to create a vserver that already > > exists, under some weird circumstances I'm not sure you'll be able to > > reproduce. At any case, it's a wrong usage and should be fixed, this > > way: > > Thanks a lot for the patch. > > But what is colorize?
colorize is a function that simply does a "echo" with some escape characters surrounding it. > > --- functions.orig 2005-12-13 23:44:28.414816664 -0500 > > +++ functions 2005-12-13 23:44:37.538429664 -0500 > > @@ -213,7 +213,7 @@ > > if test -n "$_VS_ERRFILE"; then > > echo "$@" >>"$_VS_ERRFILE" > > else > > - colorize echo -n "$@" >&2 > > + colorize error echo -n "$@" >&2 > > fi > > echo > > > > > > As I said, it's trivial, benign, but should be fixed and I don't know > > where else to report this. > > I suggest you also file this upstream. See http://linux-vserver.org/ > or just simply send an email to vserver@list.linux-vserver.org describing > this. i was kind of expecting you to do this, but I can do it.. :) Let's just CC the list... A.
signature.asc
Description: Digital signature
