Bug#777420: dictionaries-common: please make debconf template output reproducible

[Chris Lamb]

Source: dictionaries-common
Version: 1.23.17
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Hi,

While working on the "reproducible builds" effort [1], we have noticed
that dictionaries-common generates debconf output with non-deterministic
output.

The attached patch ensures a sorted order rather than arbitrary dict
order.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-

diff --git a/scripts/perl5/Devel/DictionariesCommon.pm.in 
b/scripts/perl5/Devel/DictionariesCommon.pm.in
index 847f1f4..2d625f6 100644
--- a/scripts/perl5/Devel/DictionariesCommon.pm.in
+++ b/scripts/perl5/Devel/DictionariesCommon.pm.in
@@ -138,7 +138,7 @@ rm -f \$tmp
   my @tmp_defaults   = ();
   my $has_elanguages;
 
-  foreach (keys %{$dicts}){
+  foreach (sort keys %{$dicts}){
     my $lang  = $dicts->{$_};
     unless ( defined $lang->{'debconf-display'} &&  
lc($lang->{'debconf-display'}) eq "no" ) {
       push (@tmp_languages,$_);